Added retry to sonic-mgmt docker container #7997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sharon Lutati <slutati@nvidia.com>
liat-grozovik
requested review from
jleveque,
keboliu and
yxieca
and removed request for
lguohan and
jleveque
keboliu
reviewed
Jul 8, 2021
| @@ -69,6 +69,7 @@ RUN pip install cffi==1.10.0 \ | |||
| tabulate \ | |||
| textfsm \ | |||
| virtualenv \ | |||
| retry \ | |||
There was a problem hiding this comment.
please make the ident aligned.
There was a problem hiding this comment.
Please use white spaces instead of tabs. If this was the problem.
yxieca
approved these changes
Jul 20, 2021
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it the motivation for this PR is to add retry_call to several test cases in the community, for example, the following cases: test_show_platform_fanstatus_mocked test_show_platform_temperature_mocked are executing a command once and comparing the output to the expected mock data, sometimes differences between the mock and the actual are causing the tests to fail. retry will make these tests more stable. retry will also be more efficient than sleep which will cause the tests to run longer because sometimes it is not necessary to sleep all that time, retry will only run a function only until it passed. How I did it added retry to the docker file How to verify it I run the tests with retry on the docker after installing the retry package Signed-off-by: Sharon Lutati <slutati@nvidia.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sharon Lutati slutati@nvidia.com
Why I did it
the motivation for this PR is to add retry_call to several test cases in the community, for example, the following cases:
are executing a command once and comparing the output to the expected mock data,
sometimes differences between the mock and the actual are causing the tests to fail.
retry will make these tests more stable.
retry will also be more efficient than sleep which will cause the tests to run longer because sometimes it is not necessary to sleep all that time, retry will only run a function only until it passed.
How I did it
added retry to the docker file
How to verify it
I run the tests with retry on the docker after installing the retry package
Which release branch to backport (provide reason below if selected)
Description for the changelog
adding retry to dockerfile so that retry module will be supported on sonic-mgmt