Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ethtool to docker-platform-monitor #8017

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

VenkatCisco
Copy link
Contributor

@VenkatCisco VenkatCisco commented Jun 29, 2021

Why I did it

ethtool can be used to query and change settings such as speed, auto- negotiation and checksum offload on many network devices, especially Ethernet devices.

How I did it

add package extension to docker-platform-monitor/Dockerfile.j2

How to verify it

ethtool -y
more examples are @ https://linuxhint.com/ethtool_commands_examples/

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

ethtool can be used to query and change settings such as speed, auto- negotiation and checksum offload on many network devices, especially Ethernet devices.

root@sonic:/# dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | grep ethtool
593     ethtool

A picture of a cute animal (not mandatory but encouraged)

@jleveque
Copy link
Contributor

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco: In the PR description, can you please indicate the installed size of this package on disk?

Done

@jleveque
Copy link
Contributor

@VenkatCisco: Is it necessary to backport this to the 201911 branch? That branch is relatively stable; we only want to backport bug fixes.

@VenkatCisco
Copy link
Contributor Author

@VenkatCisco: Is it necessary to backport this to the 201911 branch? That branch is relatively stable; we only want to backport bug fixes.

Our primary development branches are 202012 and azure/master. Updated the PR accordingly.

@jleveque jleveque changed the title add ethtool to docker-platform-monitor Add ethtool to docker-platform-monitor Jun 30, 2021
@jleveque jleveque merged commit 1618aec into sonic-net:master Jun 30, 2021
qiluo-msft pushed a commit that referenced this pull request Jul 7, 2021
#### Why I did it
ethtool can be used to query and change settings such as speed, auto- negotiation and checksum offload on many network devices, especially Ethernet devices. 

#### How I did it
add package extension to docker-platform-monitor/Dockerfile.j2
@keboliu
Copy link
Collaborator

keboliu commented Jul 8, 2021

I think this commit is not necessary, ethtool should already been installed in pmon container, please check PR #5725 @VenkatCisco did you see ethtool missing in the pmon docker before this commit?

lguohan added a commit that referenced this pull request Jul 8, 2021
lguohan added a commit that referenced this pull request Jul 8, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
#### Why I did it
ethtool can be used to query and change settings such as speed, auto- negotiation and checksum offload on many network devices, especially Ethernet devices. 

#### How I did it
add package extension to docker-platform-monitor/Dockerfile.j2
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants