[dhcp_relay] Enhance DHCP monitor application to support DHCPv6 #8060
Conversation
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
src/dhcpmon/src/dhcp_device.c
Outdated
| case DHCPv6_MESSAGE_TYPE_REPLY: | ||
| case DHCPv6_MESSAGE_TYPE_RECONFIGURE: | ||
| case DHCPv6_MESSAGE_TYPE_INFORMATION_REQUEST: | ||
| case DHCPv6_MESSAGE_TYPE_RELAY_FORWARD: |
There was a problem hiding this comment.
can we get rid of relay-forward and relay-reply message types and count inner message against DHCPv6 message type?
There was a problem hiding this comment.
@tahmed-dev I changed the code to fit your suggestion, please review.
Thanks
There was a problem hiding this comment.
Thanks. I noticed now that the parser will point to inner type of encapped packet. Can we remove the Relay Forward and Relay Reply from this case and let them fall through to the default section as this should not be expected.
src/dhcpmon/src/dhcp_device.c
Outdated
| case DHCPv6_MESSAGE_TYPE_REPLY: | ||
| case DHCPv6_MESSAGE_TYPE_RECONFIGURE: | ||
| case DHCPv6_MESSAGE_TYPE_INFORMATION_REQUEST: | ||
| case DHCPv6_MESSAGE_TYPE_RELAY_FORWARD: |
There was a problem hiding this comment.
Thanks. I noticed now that the parser will point to inner type of encapped packet. Can we remove the Relay Forward and Relay Reply from this case and let them fall through to the default section as this should not be expected.
…kets will be counted. Handling of these packets type is not expected.
|
i saw tamer approved, but now it is not in the status. @tahmed-dev, can you approve? |
#### Why I did it Enhance DHCP monitor application following the implementation PR: #7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR.
…c-net#8060) #### Why I did it Enhance DHCP monitor application following the implementation PR: sonic-net#7772 #### How I did it Add the support for monitoring DHCPv6 packets. #### How to verify it Install an image with this PR and the implementation PR. (cherry picked from commit bef5477)
…v6 (sonic-net#8060)" This reverts commit bef5477.
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
Why I did it
Enhance DHCP monitor application following the implementation PR: #7772
How I did it
Add the support for monitoring DHCPv6 packets.
How to verify it
Install an image with this PR and the implementation PR.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)