[Juniper] Migrating to SONiC Platform API package

[ciju-juniper]

This patch set introduce platform API package for QFX5210 & QFX5200 platforms

Signed-off-by: Ciju Rajan K crajank@juniper.net

[ciju-juniper]

Test logs on both the platforms are attached:

QFX5210_commands_log.txt

QFX5200_command_log.txt

[lgtm-com]

This pull request introduces 57 alerts and fixes 4 when merging 8698f9b2838165389b5578969695125369f19d78 into f14430b - view on LGTM.com

new alerts:

• 25 for Unused import
• 17 for Wrong number of arguments in a class instantiation
• 6 for Unused local variable
• 3 for Unreachable code
• 2 for Module imports itself
• 2 for 'import *' may pollute namespace
• 2 for Variable defined multiple times

fixed alerts:

• 4 for Unused import

[lgtm-com]

This pull request introduces 27 alerts and fixes 4 when merging 2d12b00023abd2f88cd4502b9ddda6fd55971f69 into 0c9862d - view on LGTM.com

new alerts:

• 17 for Wrong number of arguments in a class instantiation
• 2 for Module imports itself
• 2 for Unused local variable
• 2 for Unreachable code
• 2 for 'import *' may pollute namespace
• 1 for Unused import
• 1 for Variable defined multiple times

fixed alerts:

• 4 for Unused import

[ciju-juniper]

@lguohan @jleveque Could you consider merging this patch set?

[ciju-juniper]

This PR fixes the issue #5986

[lgtm-com]

This pull request introduces 27 alerts and fixes 4 when merging 40320e262a7ac1bff0977c2e18b2636c4d2e27f8 into 0c9862d - view on LGTM.com

new alerts:

• 17 for Wrong number of arguments in a class instantiation
• 2 for Module imports itself
• 2 for Unused local variable
• 2 for Unreachable code
• 2 for 'import *' may pollute namespace
• 1 for Unused import
• 1 for Variable defined multiple times

fixed alerts:

• 4 for Unused import

[ciju-juniper]

@lguohan @jleveque Could you review and approve the patches? This patch set will make Juniper platforms functional on master branch which was broken for a while.

[ciju-juniper]

@lguohan @jleveque Could you please take a look?

[lguohan]

can you fix lgtm alerts?

[ciju-juniper]

@lguohan Most of the alerts are due to this warning Wrong number of arguments to constructor initialization from a for loop.

Eg:
thermal = Thermal(idx)

For which constructor is having the initialization routine
def init(self, thermal_index=0):

I'm not sure what is wrong with the call / definitions. I've already suppressed it using '#lgtm [py/call/wrong-number-class-arguments]',

[ciju-juniper]

@lguohan All the false positive warnings are marked with the comment '#lgtm [...]'. You could see it by opening the lgtm link: https://lgtm.com/projects/g/Azure/sonic-buildimage/rev/pr-f582fa5952ed702151a827f96acf2f5d1bf5f363

Lgtm says, the warnings will go away only when the pull request is merged, if the updates are made from a pull request.

Please merge the patch set.

[ciju-juniper]

@lguohan Would you be able to merge this patch set as there is no way as per the LGTM to show the warnings as zero in the pull request?

[lgtm-com]

This pull request introduces 27 alerts and fixes 4 when merging df935a3 into 5e435e0 - view on LGTM.com

new alerts:

• 17 for Wrong number of arguments in a class instantiation
• 2 for Module imports itself
• 2 for Unused local variable
• 2 for Unreachable code
• 2 for 'import *' may pollute namespace
• 1 for Unused import
• 1 for Variable defined multiple times

fixed alerts:

• 4 for Unused import

[ciju-juniper]

Closing this pull request as lgtm is not able to show the fixed alerts.