Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WARM-REBOOT] [Mellanox] fix watchdog issue on mellanox simulator platform when executing warm-reboot #8132

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

tomer-israel
Copy link
Contributor

@tomer-israel tomer-israel commented Jul 8, 2021

[WARM-REBOOT] fix issue of watch-dog on mellanox simulator platform when executing warm-reboot

Why I did it

to prevent python exception error when executing warm-reboot command on mellanox simulator platform

How I did it

return None on the watchdog python script on cases that watchdog file is not exist

How to verify it

warm-reboot is running well without the python error. error message will appear on log on these cases.
in order to avoid this error message we can simulate the watchdog on mellanox simulator platform

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

[WARM-REBOOT] fix issue of watch-dog on mellanox simulator platform when executing warm-reboot

@tomer-israel tomer-israel requested a review from lguohan as a code owner July 8, 2021 19:27
@tomer-israel
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik requested a review from yxieca July 13, 2021 08:57
@liat-grozovik liat-grozovik changed the title [WARM-REBOOT] [Mellanox] fix watch-dog issue on mellanox simulator platform when executing warm-reboot [WARM-REBOOT] [Mellanox] fix watchdog issue on mellanox simulator platform when executing warm-reboot Jul 19, 2021
@liat-grozovik liat-grozovik merged commit a328fd2 into sonic-net:master Jul 19, 2021
qiluo-msft pushed a commit to qiluo-msft/sonic-buildimage that referenced this pull request Jul 20, 2021
…t command (sonic-net#8132)

- Why I did it
to prevent python exception error when executing warm-reboot command on mellanox simulator platform

- How I did it
return None on the watchdog python script on cases that watchdog file is not exist

- How to verify it
warm-reboot is running well without the python error. error message will appear on log on these cases.
in order to avoid this error message we can simulate the watchdog on mellanox simulator platform
judyjoseph pushed a commit that referenced this pull request Aug 4, 2021
…t command (#8132)

- Why I did it
to prevent python exception error when executing warm-reboot command on mellanox simulator platform

- How I did it
return None on the watchdog python script on cases that watchdog file is not exist

- How to verify it
warm-reboot is running well without the python error. error message will appear on log on these cases.
in order to avoid this error message we can simulate the watchdog on mellanox simulator platform
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…t command (sonic-net#8132)

- Why I did it
to prevent python exception error when executing warm-reboot command on mellanox simulator platform

- How I did it
return None on the watchdog python script on cases that watchdog file is not exist

- How to verify it
warm-reboot is running well without the python error. error message will appear on log on these cases.
in order to avoid this error message we can simulate the watchdog on mellanox simulator platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants