[redis-cli][multiasic]redis-cli supports namespace

[mlok-nokia]

The current redis-cli has been hardcoded only to access to the host database. MThis change modifies the redis-cli to identify the namespace and access to its database

[mlok-nokia]

@lguohan Could you please help to review this change or assign the the right person to review it?

[anshuv-mfst]

@arlakshm - FYI

[arlakshm]

sonic-db-cli can to be used instead of redis-cli for multi-asic platforms.
sonic-db-cli has the -n namspace option implemented.
Link to earlier discussion on this for context #3888 (comment)

[judyjoseph]

This PR could be closed in favor of using sonic-db-cli

[sanmalho-git]

@arlakshm - redis-cli is still in use in a lot of tests in sonic-mgmt. Is there a plan to modify all tests in sonic-mgmt to use sonic-db-cli?

[arlakshm]

Hi @sanmalho-git , sonic-mgmt has function run_redis_cli_cmd to run the redis-cli on Asic or device. I think that should help.

[sanmalho-git]

/usr/bin/redis-cli in the host and in the netns is hard-coded to use the global 'database'.

docker exec -$DOCKER_EXEC_FLAGS database redis-cli "$@"

So, regardless of whether I add 'sudo ip netns exec' to the redis-cli command or not, it still goes to the global 'database'. As an example on a multi-asic box, keys PORT* in CONFIG_DB at the host level are:

admin@sonic:~$ redis-cli -n 4 keys "PORT*"
 1) "PORT|Ethernet7"
 2) "PORT|Ethernet4"
 3) "PORTCHANNEL_INTERFACE|PortChannel0001|FC00::19/126"
 4) "PORTCHANNEL_MEMBER|PortChannel0005|Ethernet27"
 5) "PORT|Ethernet28"
 6) "PORTCHANNEL|PortChannel0001"
 7) "PORTCHANNEL_MEMBER|PortChannel0001|Ethernet7"
 8) "PORTCHANNEL_INTERFACE|PortChannel0005"
 9) "PORT|Ethernet26"
10) "PORTCHANNEL_INTERFACE|PortChannel0005|FC00::25/126"
11) "PORTCHANNEL|PortChannel0005"
12) "PORTCHANNEL_MEMBER|PortChannel0005|Ethernet26"
13) "PORTCHANNEL_INTERFACE|PortChannel0001"
14) "PORT|Ethernet27"
15) "PORTCHANNEL_INTERFACE|PortChannel0005|10.0.0.18/31"
16) "PORTCHANNEL_INTERFACE|PortChannel0001|10.0.0.12/31"
17) "PORTCHANNEL_MEMBER|PortChannel0001|Ethernet4"
18) "PORT|Ethernet10"

Doing the above command in asic0 namespace gives the same result:

admin@sonic:~$ sudo ip netns exec asic0 redis-cli -n 4 keys "PORT*"
 1) "PORT|Ethernet7"
 2) "PORT|Ethernet4"
 3) "PORTCHANNEL_INTERFACE|PortChannel0001|FC00::19/126"
 4) "PORTCHANNEL_MEMBER|PortChannel0005|Ethernet27"
 5) "PORT|Ethernet28"
 6) "PORTCHANNEL|PortChannel0001"
 7) "PORTCHANNEL_MEMBER|PortChannel0001|Ethernet7"
 8) "PORTCHANNEL_INTERFACE|PortChannel0005"
 9) "PORT|Ethernet26"
10) "PORTCHANNEL_INTERFACE|PortChannel0005|FC00::25/126"
11) "PORTCHANNEL|PortChannel0005"
12) "PORTCHANNEL_MEMBER|PortChannel0005|Ethernet26"
13) "PORTCHANNEL_INTERFACE|PortChannel0001"
14) "PORT|Ethernet27"
15) "PORTCHANNEL_INTERFACE|PortChannel0005|10.0.0.18/31"
16) "PORTCHANNEL_INTERFACE|PortChannel0001|10.0.0.12/31"
17) "PORTCHANNEL_MEMBER|PortChannel0001|Ethernet4"
18) "PORT|Ethernet10"

But if we use 'docker exec database0' we get the correct keys:

admin@sonic:~$ docker exec database0  redis-cli -n 4 keys "PORT*"
PORT|Ethernet2
PORT|Ethernet14
PORTCHANNEL|PortChannel0001
PORT|Ethernet1
PORTCHANNEL_INTERFACE|PortChannel0001
PORT|Ethernet6
PORT|Ethernet11
PORT|Ethernet4
PORT|Ethernet12
PORTCHANNEL_MEMBER|PortChannel0001|Ethernet7
PORT|Ethernet16
PORTCHANNEL_INTERFACE|PortChannel0001|10.0.0.12/31
PORT|Ethernet10
PORT|Ethernet17
PORT|Ethernet0
PORT|Ethernet7
PORTCHANNEL_MEMBER|PortChannel0001|Ethernet4
PORT|Ethernet-IB0
PORTCHANNEL_INTERFACE|PortChannel0001|FC00::19/126
PORT|Ethernet3
PORT|Ethernet13
PORT|Ethernet9
PORT|Ethernet15
PORT|Ethernet8
PORT|Ethernet5

So, in sonic-mgmt, should run_redis_cli_cmd should do 'docker exec' instead of 'sudo ip netns exec'?