Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AS7816-64x] Modify util to support python3 #8253

Merged

Conversation

jostar-yang
Copy link
Contributor

Signed-off-by: Jostar Yang jostar_yang@accton.com.tw

Why I did it

  1. Modify accton_as7816_util.py to support python3
  2. Remove not needed code.

How I did it

Modify accton_as7816_util.py

How to verify it

Test "./accton_as7816_util.py install" and "./accton_as7816_util.py clean". Results are fine

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
@jostar-yang jostar-yang requested a review from lguohan as a code owner July 23, 2021 08:58
@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2021

This pull request introduces 1 alert when merging 94930ae into 7698747 - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lguohan lguohan merged commit f929c3b into sonic-net:master Jul 24, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants