DellEMC: Z9332f platform API changes #8258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
reviewed
Jul 26, 2021
There was a problem hiding this comment.
is_xcvr_optical() needs fix for QSFP-DD https://github.com/Azure/sonic-mgmt/blob/5697eea34d4d5261ff69350098ce67188b8b1c81/tests/platform_tests/api/test_sfp.py#L150
platform/broadcom/sonic-platform-modules-dell/z9332f/sonic_platform/sfp.py
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-dell/z9332f/sonic_platform/sfp.py
Outdated
Show resolved
Hide resolved
sonic-net/sonic-mgmt#3888 has been raised to fix the test script issue. |
prgeor
approved these changes
Jul 27, 2021
sujinmkang
approved these changes
Aug 6, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Aug 7, 2021
Why I did it platform test suite failed for few API's in DellEMC Z9332f platform. How I did it Modified the API's to return the expected values in the script. How to verify it Run platform test suite after making the changes.
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 7, 2021
Why I did it platform test suite failed for few API's in DellEMC Z9332f platform. How I did it Modified the API's to return the expected values in the script. How to verify it Run platform test suite after making the changes.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Why I did it platform test suite failed for few API's in DellEMC Z9332f platform. How I did it Modified the API's to return the expected values in the script. How to verify it Run platform test suite after making the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
platform test suite failed for few API's in DellEMC Z9332f platform.
How I did it
Modified the API's to return the expected values in the script.
How to verify it
Run platform test suite after making the changes.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Platform test suite has passed after making the API changes.
UT:
z9332f_UT.txt
A picture of a cute animal (not mandatory but encouraged)