Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed changelog file - 1 space at start of line, 2 spaces before day #8317

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

raphaelt-nvidia
Copy link
Contributor

Signed-off-by: Raphael Tryster raphaelt@nvidia.com

Why I did it

Malformed changelog file causes build to fail when SONIC_PROFILING_ON = y.

How I did it

Changed the number and position of spaces in the file.

How to verify it

In rules/config, uncomment the line: SONIC_PROFILING_ON = y
make configure PLATFORM=mellanox
make target/sonic-mellanox.bin-clean
make target/sonic-mellanox.bin

Expect NOT to see warnings or errors relating to debian/changelog, such as
dpkg-genchanges: warning: debian/changelog(l3): found end of file where expected more change data or trailer

However, the build may still fail as long as Azure#8316 is not fixed, due to another issue.

Which release branch to backport (provide reason below if selected)

Description for the changelog

Fixed changelog format.

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
@lguohan lguohan merged commit 2bb9f0b into sonic-net:master Aug 4, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Malformed changelog file causes build to fail when SONIC_PROFILING_ON = y.

Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants