Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Autorestart of the daemons in PMON for unexpected exit #8326

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

sujinmkang
Copy link
Collaborator

@sujinmkang sujinmkang commented Aug 4, 2021

Why I did it

To fix the issue #8239

How I did it

Enable Autorestart of the daemons in PMON for unexpected exit
Remove the daemon list from the critical_process which prevent the PMON
from restarting when the individual daemon crashes.

How to verify it

Run sonic-mgmt/tests/platform-test/daemon/test_ledd.py and
verify the test_pmon_ledd_kill_and_start_status

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Remove the daemon list from the critical_process which prevent the PMON
from restarting when the individual daemon crashes.
@sujinmkang sujinmkang requested a review from lguohan as a code owner August 4, 2021 02:19
@lguohan
Copy link
Collaborator

lguohan commented Aug 4, 2021

@sujinmkang , can you test this on 202012 branch as well?

@qiluo-msft
Copy link
Collaborator

This PR could not be cleanly cherry-pick to 202012. Please submit another PR.

judyjoseph pushed a commit that referenced this pull request Aug 7, 2021
… cases (#8326)

Remove the daemon list from the critical_process which prevent the PMON
from restarting when the individual daemon crashes.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
… cases (sonic-net#8326)

Remove the daemon list from the critical_process which prevent the PMON
from restarting when the individual daemon crashes.
@liat-grozovik
Copy link
Collaborator

@sujinmkang can you please create a PR against 202012? it is not cleanly cherry picked.

@sujinmkang
Copy link
Collaborator Author

@liat-grozovik I already created a PR(#8358) for 202012 and it's merged to 202012.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[202012] test_pmon_ledd_kill_and_start_status is consistently failing
5 participants