Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] BRCM Disable ACL Drop counted towards interface RX_DRP counters #8383

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Conversation

gechiang
Copy link
Collaborator

@gechiang gechiang commented Aug 9, 2021

Why I did it

For all BRCM ACL Drops there is a way not to count these packet drops towards the interface RX_DRP counters by enabling a new SOC property. This SOC property is being enabled on the chosen BRCM HW SKUs config.bcm files.

How to verify it

Send packet that is expected to be drop due to ACL and check that it is not being counted towards interface RX_DRP counter.
Also tested on S6100, 7260, and TD3 WARM Reboot scenario where this SOC property was not present before the WARM Reboot but become enabled after WARM Reboot.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

Add SOC property to not count ACL Drops towards interface RX_DRP for All BRCM HW SKUs.

A picture of a cute animal (not mandatory but encouraged)

@gechiang
Copy link
Collaborator Author

gechiang commented Aug 9, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gechiang gechiang merged commit 8915e48 into sonic-net:202012 Aug 11, 2021
@gechiang
Copy link
Collaborator Author

This was approved indirectly by Prince for
#8382
the two are exact same changes one for master branch (8382) while this one is for 202012 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants