Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-py-swsssdk]: Update sonic-py-swsssdk submodule #8681

Closed
wants to merge 1 commit into from

Conversation

mlok-nokia
Copy link
Contributor

Signed-off-by: mlok marty.lok@nokia.com

Why I did it

Update sonic-py-swsssdk submodule to include below commits:
d07682e Merge pull request #111 from xumia/azp-coverage
482cac2 [Ethernet-IB][index] Modifed the port_util to support the VoQ Inband Port (#113)
69eac92 Support azp diff coverage

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@mlok-nokia mlok-nokia requested a review from lguohan as a code owner September 3, 2021 17:28
@mlok-nokia
Copy link
Contributor Author

@SuvarnaMeenakshi @qiluo-msft Please review this PR, Thanks

@yozhao101
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes Sep 7, 2021
@mlok-nokia
Copy link
Contributor Author

@qiluo-msft The build failed. Should I rebase and re-run? or Another suggestion?

@anshuv-mfst
Copy link

anshuv-mfst commented Sep 8, 2021

@judyjoseph - FYI, as discussed in subgroup meeting please help with re-run.

@yozhao101
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Collaborator

In sonic-utilities unit test
sonic-net/sonic-py-swsssdk@6be76f4...740a44c#diff-70932c8be17fb6930f6e4498f1a6335bbb2d925e76b174f44222619b46092f61R69

    if_name_map = db.get_all('COUNTERS_DB', 'COUNTERS_PORT_NAME_MAP', blocking)

This line actually calls swsssdk SonicV2Connector.get_all(). That function could not accept blocking as a positional argument. This is a bug in swsssdk repo.

@mlok-nokia
Copy link
Contributor Author

In sonic-utilities unit test
Azure/sonic-py-swsssdk@6be76f4...740a44cdiff-70932c8be17fb6930f6e4498f1a6335bbb2d925e76b174f44222619b46092f61R69

    if_name_map = db.get_all('COUNTERS_DB', 'COUNTERS_PORT_NAME_MAP', blocking)

This line actually calls swsssdk SonicV2Connector.get_all(). That function could not accept blocking as a positional argument. This is a bug in swsssdk repo.

Since this bug is introduced by last commit in the sonic-py-swsssdk, I just updated the submodule up to the previous commit. And I will log note to that PR (which has been merged) to let the author know that it is a bug. Thanks

@yozhao101
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes Sep 10, 2021
Update sonic-py-swsssdk submodule to include below commits:
9da577d [port_util] Fix issue in function get_interface_oid_map (sonic-net#114)
740a44c [port_util] Allow system without ports in config db run without errors (sonic-net#109)

d07682e Merge pull request sonic-net#111 from xumia/azp-coverage
482cac2 [Ethernet-IB][index] Modifed the port_util to support the VoQ Inband Port (sonic-net#113)
69eac92 Support azp diff coverage

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia
Copy link
Contributor Author

Duplicated with 8757

@mlok-nokia mlok-nokia closed this Sep 15, 2021
@mlok-nokia mlok-nokia deleted the update-submodule branch April 16, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants