[hostcfgd] [202106] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 tasks
qiluo-msft
reviewed
Oct 28, 2021
|
|
||
|
|
||
| def safe_eval(val, default_value=False): | ||
| """ Safely evaluate the expression, without raising an exception """ |
There was a problem hiding this comment.
I notice you change comment during backport. Could you also update master branch?
Better to finish everything on master, and backport together.
There was a problem hiding this comment.
Hi @qiluo-msft, i did make the same commit in the master as well. f76a73e
There was a problem hiding this comment.
Sorry, I mean the word Safely evaluate the expression, without raising an exception
There was a problem hiding this comment.
Oh..k get it. Should i raise a separate PR for master for this typo?
There was a problem hiding this comment.
Raised here: #9113
|
@qiluo-msft Can we merge this? |
qiluo-msft
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
Why I did it
Ported #8861 to 202106 as it couldn't be cherry-pick directly
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)