[dhcp_relay] fix data type in dhcp6relay, add protection in packet data parsing #9036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiarcot895
reviewed
Oct 21, 2021
yxieca
reviewed
Oct 21, 2021
yxieca
approved these changes
Oct 22, 2021
yxieca
pushed a commit
that referenced
this pull request
Oct 22, 2021
5 tasks
yxieca
pushed a commit
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Error in socket receiver, causing dhcp6relay to be stuck in infinite while loop when parsing through packet data.
How I did it
Fix recv datatype, add a protection check to check if the next pointer of packet is the same as current pointer.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)
Signed off by Kelly Yeh kellyyeh@microsoft.com