Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC SFP Refactor #9142

Merged
merged 8 commits into from
Nov 17, 2021
Merged

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented Nov 2, 2021

Why I did it

Since SFP refactor has common API's, redundant platform API has to be removed.

How I did it

Removed redundant SFP API in DellEMC platforms.

How to verify it

Execute "sfpshow eeprom -d", verify syslogs pertaining to pmon, OIR tests etc..
z9332f_ut.txt

Note:
Please merge this PR only when sonic-platform-common submodule is updated with sonic_xcvr package in sonic-buildimage repo.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Nov 2, 2021

This pull request introduces 5 alerts and fixes 3 when merging 356a885 into fcff3f3 - view on LGTM.com

new alerts:

  • 5 for Syntax error

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@prgeor
Copy link
Contributor

prgeor commented Nov 8, 2021

@aravindmani-1 please test the case where a user plugs-out and plugs-in a different sfp type

  1. QSFP+/QSFP28 -> QSFP-DD
  2. QSFP-DD -> QSFP+/QSFP28

Ensure the APIs created by the xcvr_api_factory.py is correctly matches to the type of sfp module inserted.

@prgeor prgeor self-assigned this Nov 8, 2021
@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented Nov 8, 2021

@aravindmani-1 please test the case where a user plugs-out and plugs-in a different sfp type

  1. QSFP+/QSFP28 -> QSFP-DD
  2. QSFP-DD -> QSFP+/QSFP28

Ensure the APIs created by the xcvr_api_factory.py is correctly matches to the type of sfp module inserted.

yes. with the OIR testing, QSFP-DD to QSFP28/QSFP+ and vice versa has been tested, it is working fine.
OIR_Test.txt

@lgtm-com
Copy link

lgtm-com bot commented Nov 10, 2021

This pull request fixes 3 alerts when merging 19e4b49 into e2bffdf - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Nov 11, 2021

This pull request fixes 3 alerts when merging fde2d68 into b8eb9f2 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@lgtm-com
Copy link

lgtm-com bot commented Nov 15, 2021

This pull request fixes 3 alerts when merging 529f3c0 into db0b789 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Unused import
  • 1 for Variable defined multiple times

@prgeor prgeor merged commit 5a56659 into sonic-net:master Nov 17, 2021
@aravindmani-1 aravindmani-1 deleted the refactor_dell_sfp branch March 11, 2022 04:21
@aravindmani-1
Copy link
Contributor Author

@prgeor @qiluo-msft Could you please help to cherry pick this PR to 202111 branch?.

@prgeor prgeor added the Request for 202111 Branch For PRs being requested for 202111 branch label May 5, 2022
@judyjoseph
Copy link
Contributor

@aravindmani-1 Please raise a separate PR for 202111 as there are conflicts

@judyjoseph judyjoseph removed the Request for 202111 Branch For PRs being requested for 202111 branch label May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants