-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DellEMC SFP Refactor #9142
DellEMC SFP Refactor #9142
Conversation
This pull request introduces 5 alerts and fixes 3 when merging 356a885 into fcff3f3 - view on LGTM.com new alerts:
fixed alerts:
|
@aravindmani-1 please test the case where a user plugs-out and plugs-in a different sfp type
Ensure the APIs created by the xcvr_api_factory.py is correctly matches to the type of sfp module inserted. |
yes. with the OIR testing, QSFP-DD to QSFP28/QSFP+ and vice versa has been tested, it is working fine. |
This pull request fixes 3 alerts when merging 19e4b49 into e2bffdf - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging fde2d68 into b8eb9f2 - view on LGTM.com fixed alerts:
|
This pull request fixes 3 alerts when merging 529f3c0 into db0b789 - view on LGTM.com fixed alerts:
|
@prgeor @qiluo-msft Could you please help to cherry pick this PR to 202111 branch?. |
@aravindmani-1 Please raise a separate PR for 202111 as there are conflicts |
Why I did it
Since SFP refactor has common API's, redundant platform API has to be removed.
How I did it
Removed redundant SFP API in DellEMC platforms.
How to verify it
Execute "sfpshow eeprom -d", verify syslogs pertaining to pmon, OIR tests etc..
z9332f_ut.txt
Note:
Please merge this PR only when sonic-platform-common submodule is updated with sonic_xcvr package in sonic-buildimage repo.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)