Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-sairedis] update submodule #9233

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

stepanblyschak
Copy link
Collaborator

6f1a0ea (HEAD, origin/master, origin/HEAD, master) [FlexCounter] Add support for ACL counters (#953)
67b3136 [vslib] fill aclcapability.is_action_list_mandatory field (#957)
eba6a1b [ci]: use native armhf and arm64 pool (#965)
04793b1 [az] Set diff coverage threshold to 50% (#963)
6092d50 [syncd] Add workaround for warm boot new objects (#960)
88b62ce Added Flex Counters support for tunnel counters (#886)
a718226 [Counters] Query Counters Stats Capabilities (#952)

Signed-off-by: Stepan Blyschak stepanb@nvidia.com

Why I did it

To bring new features in sonic-sairedis.

How I did it

Updated submodule.

How to verify it

Build and run.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

```
6f1a0ea (HEAD, origin/master, origin/HEAD, master) [FlexCounter] Add support for ACL counters (sonic-net#953)
67b3136 [vslib] fill aclcapability.is_action_list_mandatory field (sonic-net#957)
eba6a1b [ci]: use native armhf and arm64 pool (sonic-net#965)
04793b1 [az] Set diff coverage threshold to 50% (sonic-net#963)
6092d50 [syncd] Add workaround for warm boot new objects (sonic-net#960)
88b62ce Added Flex Counters support for tunnel counters (sonic-net#886)
a718226 [Counters] Query Counters Stats Capabilities (sonic-net#952)
```

Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
@stepanblyschak
Copy link
Collaborator Author

Seems it will be blocked till BRCM SAI updates with the new SAI API added sai_query_stats_capability:

/bin/bash ../libtool  --tag=CXX   --mode=link g++ -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -I../lib -I../vslib -ansi -fPIC -std=c++14 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Wno-inline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -Wno-switch-default -Wconversion -Wno-psabi -Wcast-align=strict    -g -O2 -fdebug-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -rdynamic -Wl,-z,relro -o syncd syncd-main.o libSyncd.a ../lib/libSaiRedis.a -L../meta/.libs -lsaimetadata -lsaimeta -ldl -lhiredis -lswsscommon -lsai -lpthread -lzmq   
libtool: link: g++ -g -I../SAI/inc -I../SAI/experimental -I../SAI/meta -I../lib -I../vslib -ansi -fPIC -std=c++14 -Wall -Wcast-align -Wcast-qual -Wconversion -Wdisabled-optimization -Werror -Wextra -Wfloat-equal -Wformat=2 -Wformat-nonliteral -Wformat-security -Wformat-y2k -Wimport -Winit-self -Wno-inline -Winvalid-pch -Wmissing-field-initializers -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wno-aggregate-return -Wno-padded -Wno-switch-enum -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wshadow -Wstack-protector -Wstrict-aliasing=3 -Wswitch -Wswitch-default -Wunreachable-code -Wunused -Wvariadic-macros -Wwrite-strings -Wno-switch-default -Wconversion -Wno-psabi -Wcast-align=strict -g -O2 -fdebug-prefix-map=/sonic/src/sonic-sairedis=. -fstack-protector-strong -Wformat -Werror=format-security -rdynamic -Wl,-z -Wl,relro -o .libs/syncd syncd-main.o  libSyncd.a ../lib/libSaiRedis.a -L../meta/.libs /sonic/src/sonic-sairedis/meta/.libs/libsaimetadata.so /sonic/src/sonic-sairedis/meta/.libs/libsaimeta.so -ldl -lhiredis -lswsscommon -lsai -lpthread -lzmq
/usr/bin/ld: libSyncd.a(libSyncd_a-VendorSai.o): in function `syncd::VendorSai::queryStatsCapability(unsigned long, _sai_object_type_t, _sai_stat_capability_list_t*)':
./syncd/VendorSai.cpp:439: undefined reference to `sai_query_stats_capability'

@lguohan
Copy link
Collaborator

lguohan commented Nov 11, 2021

do we need full implementation for just dummy function is ok?

@liat-grozovik
Copy link
Collaborator

@shlomibitton IMO your implementation can assume API is not supported and then it is back to current implementation. so I think not supported should work.

@lguohan
Copy link
Collaborator

lguohan commented Nov 14, 2021

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@lguohan
Copy link
Collaborator

lguohan commented Nov 14, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stepanblyschak
Copy link
Collaborator Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft merged commit ca3a034 into sonic-net:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants