Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[centec] support v682-48y8c and v682-48x8c #9349

Merged

Conversation

LuiSzee
Copy link
Contributor

@LuiSzee LuiSzee commented Nov 23, 2021

Why I did it

Adding platform support for centec v682-48y8c and v682-48x8c.
V682-48y8c switch has 48 SFP+ (1G/10G/25G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
V682-48y8c is different from V682-48y8c_d in that:

  1. transceiver is managed by cpu smbus rather than TsingMa.MX i2c bus.
  2. port led is managed by mcu inside TsingMa.MX.
  3. fan, psu, sensors, leds are managed by cpu smbus other than the cpu board vendor's close sourse driver.

V682-48x8c switch has 48 SFP+ (1G/10G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
CPU used in v682-48y8c and v682-48x8c is Intel(R) Xeon(R) CPU D-1527.

How I did it

  1. Modify related code in platform and device directory.
  2. Upgrade centec sai to v1.9.
  3. upgrade python to python3 and kernel version to 5.0 for V682-48y8c_d.

How to verify it

Build centec amd64 sonic image, verify platform functions (port, sfp, led etc) on centec v682-48y8c and v682-48x8c board.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  1. fix syncd compile error: undefined reference to sai_query_stats_capability on 202111
  2. upgrade v682_48y8c-d support to bullseye and linux 5.10 on 202111

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@LuiSzee LuiSzee requested a review from lguohan as a code owner November 23, 2021 02:19
@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2021

This pull request introduces 10 alerts when merging 1822ec7 into 848a171 - view on LGTM.com

new alerts:

  • 10 for Wrong number of arguments in a class instantiation

@LuiSzee
Copy link
Contributor Author

LuiSzee commented Nov 23, 2021

Please help to review this PR, Thanks very much, @lguohan @sujinmkang
Here is the show platform command output on v682-48x8c:
https://github.com/LuiSzee/tests/blob/main/centec/show_platform_v682_48x8c.txt

@sujinmkang
Copy link
Collaborator

@LuiSzee Do you have command output for v682-48y8c too? And PR description has the v682-48y8c information but it doesn't have v682-48x8c information. Can you also share the output of "docker exec pmon supervisorctl status"?

@LuiSzee
Copy link
Contributor Author

LuiSzee commented Dec 1, 2021

@LuiSzee Do you have command output for v682-48y8c too? And PR description has the v682-48y8c information but it doesn't have v682-48x8c information. Can you also share the output of "docker exec pmon supervisorctl status"?

Here is the show platform command output on v682-48y8c and v682-48x8c, i also add the output of "docker exec pmon supervisorctl status":
https://github.com/LuiSzee/tests/blob/main/centec/show_platform_v682_48y8c.txt
https://github.com/LuiSzee/tests/blob/main/centec/show_platform_v682_48x8c.txt

V682-48x8c switch has 48 SFP+ (1G/10G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX, and has similar peripheral device design with V682-48y8c.

@guxianghong
Copy link
Contributor

Please help to review this PR, this PR will upgrade centec sai to v1.9 which will fix the compile problem.
Thanks very much. @lguohan @sujinmkang

@sujinmkang sujinmkang merged commit 9e19a9a into sonic-net:master Dec 17, 2021
@sujinmkang sujinmkang added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 20, 2021
judyjoseph pushed a commit that referenced this pull request Dec 27, 2021
Why I did it
Adding platform support for centec v682-48y8c and v682-48x8c.
V682-48y8c switch has 48 SFP+ (1G/10G/25G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
V682-48y8c is different from V682-48y8c_d in that:

transceiver is managed by cpu smbus rather than TsingMa.MX i2c bus.
port led is managed by mcu inside TsingMa.MX.
fan, psu, sensors, leds are managed by cpu smbus other than the cpu board vendor's close sourse driver.
V682-48x8c switch has 48 SFP+ (1G/10G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
CPU used in v682-48y8c and v682-48x8c is Intel(R) Xeon(R) CPU D-1527.

How I did it
Modify related code in platform and device directory.
Upgrade centec sai to v1.9.
upgrade python to python3 and kernel version to 5.0 for V682-48y8c_d.
How to verify it
Build centec amd64 sonic image, verify platform functions (port, sfp, led etc) on centec v682-48y8c and v682-48x8c board.

Co-authored-by: shil <shil@centecnetworks.com>
LuiSzee added a commit to CentecNetworks/sonic-buildimage that referenced this pull request Mar 26, 2022
Why I did it
Adding platform support for centec v682-48y8c and v682-48x8c.
V682-48y8c switch has 48 SFP+ (1G/10G/25G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
V682-48y8c is different from V682-48y8c_d in that:

transceiver is managed by cpu smbus rather than TsingMa.MX i2c bus.
port led is managed by mcu inside TsingMa.MX.
fan, psu, sensors, leds are managed by cpu smbus other than the cpu board vendor's close sourse driver.
V682-48x8c switch has 48 SFP+ (1G/10G) ports, 8 QSFP28 (40G/100G) ports on CENTEC TsingMa.MX.
CPU used in v682-48y8c and v682-48x8c is Intel(R) Xeon(R) CPU D-1527.

How I did it
Modify related code in platform and device directory.
Upgrade centec sai to v1.9.
upgrade python to python3 and kernel version to 5.0 for V682-48y8c_d.
How to verify it
Build centec amd64 sonic image, verify platform functions (port, sfp, led etc) on centec v682-48y8c and v682-48x8c board.

Co-authored-by: shil <shil@centecnetworks.com>
@shihjeff
Copy link

shihjeff commented Jul 7, 2022

@sujinmkang - can you add "Request for 202111 branch" label so branch owner can cherrypick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants