[sonic-py-common] Add recirc_prefix definition #9471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interface type is used for recirculation on chassis. The definition is required to prevent this interface from being considered a physical interface in sonic-platform-common and sonic-platform-daemon
This was referenced Dec 8, 2021
judyjoseph
approved these changes
Dec 10, 2021
judyjoseph
added
the
Request for 202111 Branch
sujinmkang
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Dec 17, 2021
Description Prevent ledd crash when an event on recirc port happens Motivation and Context A recirculation port is not a physical interface tied to a xcvr Calling the led change event on such a port could lead to a ledd crash How Has This Been Tested? This change was applied to running switch with its dependency sonic-net/sonic-buildimage#9471 Verified that ledd runs without crashing
judyjoseph
pushed a commit
that referenced
this pull request
Dec 27, 2021
This interface type is used for recirculation on chassis. The definition is required to prevent this interface from being considered a physical interface in sonic-platform-common and sonic-platform-daemon
judyjoseph
pushed a commit
to sonic-net/sonic-platform-daemons
that referenced
this pull request
Jan 23, 2022
Description Prevent ledd crash when an event on recirc port happens Motivation and Context A recirculation port is not a physical interface tied to a xcvr Calling the led change event on such a port could lead to a ledd crash How Has This Been Tested? This change was applied to running switch with its dependency sonic-net/sonic-buildimage#9471 Verified that ledd runs without crashing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This interface type is used for recirculation on chassis.
The definition is required to prevent this interface from being
considered a physical interface in sonic-platform-common and sonic-platform-daemon
Which release branch to backport (provide reason below if selected)
Required for chassis work
Description for the changelog
Add recirc_prefix definition in sonic_py_common