-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PDDF kernel modules with 5.10 kernel and fix some compilation … #9582
Conversation
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 9582 in repo Azure/sonic-buildimage |
/azpw run |
/AzurePipelines run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are ok to me.
/azp run Azure.sonic-buildimage |
Commenter does not have sufficient privileges for PR 9582 in repo Azure/sonic-buildimage |
/azpw run |
f6c136c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Th changes are fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is fine to me.
525c5b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ilation (sonic-net#9582) - Why I did it There were compilation errors and warnings like, /usr/src/linux-headers-5.10.0-8-2-common/scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead. fatal error: linux/platform_data/pca954x.h: No such file or directory hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info(). If PDDF kernel module compilation fails, the PDDF debian package was not detecting the break. - How I did it Modified the code with new kernel 5.10 APIs. Modified the Makefiles to use 'obj-m' instead of 'subdir-y' - How to verify it PDDF is supported on Accton platform. Load the build on AS7326 setup and check the 'dmesg'
@prgeor @vdahiya12 |
…warnings
Why I did it
There were compilation errors and warnings like,
How I did it
How to verify it
Some logs are here,
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)