Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added platform.json in Mellanox Spectrum-4 and older simx platforms #9621

Merged

Conversation

raphaelt-nvidia
Copy link
Contributor

Signed-off-by: Raphael Tryster raphaelt@nvidia.com

Why I did it

Added missing functionality for dynamic buffer calculation in Spectrum-4.

How I did it

Added a section of code in asic_table.j2 for Spectrum-4, and added the simx version of SN5600 to the supported list.

How to verify it

Manually: buffershow -l should show all ingress/egress lossy/lossless pools, and all fields of profiles should show values.
Automatically: https://github.com/Azure/sonic-mgmt/blob/master/tests/qos/test_buffer.py

Which release branch to backport (provide reason below if selected)

Description for the changelog

Filled in Spectrum-4 support in asic_table.j2

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@stephenxs please review

@stephenxs
Copy link
Collaborator

Hi @raphaelt-nvidia
Do we need platform.json in all simx platforms? If we do, I suggest changing the title or having them in another PR.

@raphaelt-nvidia raphaelt-nvidia changed the title Filled in Nvidia Spectrum-4 support in asic_table.j2 Added platform.json in Mellanox Spectrum-4 and older simx platforms Dec 28, 2021
stephenxs
stephenxs previously approved these changes Dec 30, 2021
…eal switches

Signed-off-by: Raphael Tryster <raphaelt@nvidia.com>
@liat-grozovik liat-grozovik merged commit c2b0af8 into sonic-net:master Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants