Enable/Disable Order ECMP feature. #9651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
shi-su
reviewed
Jan 6, 2022
| @@ -20,7 +20,12 @@ | |||
| "SWITCH_TABLE:switch": { | |||
| "ecmp_hash_seed": "{{ hash_seed_value }}", | |||
| "lag_hash_seed": "{{ hash_seed_value }}", | |||
| "fdb_aging_time": "600" | |||
| "fdb_aging_time": "600", | |||
| {% if DEVICE_METADATA.localhost.type and "LeafRouter" in DEVICE_METADATA.localhost.type %} | |||
There was a problem hiding this comment.
Just wanted to confirm. In the design, whether ordered ECMP is enabled is only dependent on the type. There will be no additional switch for it?
There was a problem hiding this comment.
yes for now device type only. There was thinking to use asic_type also but now we are using sai query capability and enable/disable based on it.
shi-su
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Updated Jinja2 Template in
switch.json.j2for enabling/disabling Order ECMP feature based on device role.Changes as per design: sonic-net/SONiC#896
How I verify:
Manual Verification for template getting generated correctly.