Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dhcp_relay] Fix import for dhcp_counters on clear_dhcp6relay_counter.py #9691

Merged
merged 1 commit into from
Jan 16, 2022
Merged

[dhcp_relay] Fix import for dhcp_counters on clear_dhcp6relay_counter.py #9691

merged 1 commit into from
Jan 16, 2022

Conversation

shlomibitton
Copy link
Contributor

@shlomibitton shlomibitton commented Jan 6, 2022

Signed-off-by: Shlomi Bitton shlomibi@nvidia.com

Why I did it

Import issue will cause:
root@sonic:/# sudo sonic-clear arp
failed to import plugin clear.plugins.dhcprelay: No module named 'show_dhcp_relay'

How I did it

Fix the import.

How to verify it

run sudo sonic-clear arp

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@shlomibitton shlomibitton changed the title Fix import error for DHCP relay CLI [dhcp_relay] Fix import for dhcp_counters on clear_dhcp6relay_counter.py Jan 6, 2022
@shlomibitton
Copy link
Contributor Author

@kellyyeh can you please review?

@liat-grozovik liat-grozovik added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 10, 2022
@liat-grozovik
Copy link
Collaborator

@shlomibitton is this not relevant for 202012 as well?

@shlomibitton
Copy link
Contributor Author

shlomibitton commented Jan 10, 2022

@shlomibitton is this not relevant for 202012 as well?

@liat-grozovik No, it is related to some change on app-ext CLI plugin naming.

@liat-grozovik liat-grozovik merged commit eaa888d into sonic-net:master Jan 16, 2022
@liat-grozovik
Copy link
Collaborator

@yxieca FYI. This merged as this prevent some automation tests to fail.

judyjoseph pushed a commit that referenced this pull request Jan 17, 2022
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
@yxieca
Copy link
Contributor

yxieca commented Jan 20, 2022

@kellyyeh can you assess if this change is needed by 202012 branch?

@kellyyeh
Copy link
Contributor

@yxieca This is not needed for 202012 branch

@shlomibitton shlomibitton deleted the shlomi_fix_dhcp_import branch March 15, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants