fix relay-reply dhcpv6 packet counter issue #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekrnv
approved these changes
Dec 27, 2022
6 tasks
|
@jcaiMR @StormLiangMS Can we merge this? |
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
This was referenced Jan 13, 2023
kellyyeh
pushed a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Feb 1, 2023
fix Advertise packets counted as Unknown
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 2, 2023
fix Advertise packets counted as Unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
fix issue sonic-net/sonic-buildimage#13083
How I did it
DHCPv6 Relay-Reply packet decode issue, original code assume Relay Message option (option 9) was the first option in Relay-Reply .
If other options exists before option9, DHCPv6 message type inside Relay-Msg will wrong.
How to verify it
Enhance sonic-mgmt dhcpv6_cpunter_test.py, use different format of Relay-Reply packets.
Test case improve:
sonic-net/sonic-mgmt#7105
Which release branch to backport (provide reason below if selected)