[202012] fix dual-tor relay-reply handing issue #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
June 7, 2023 13:56
kellyyeh
reviewed
Jun 21, 2023
added 2 commits
June 22, 2023 03:04
vivekrnv
reviewed
Jun 28, 2023
vivekrnv
suggested changes
Jun 28, 2023
vivekrnv
suggested changes
Jul 3, 2023
added 2 commits
July 7, 2023 13:33
…-dhcp-relay into dev/jcai_202012_dualtor_fix
11 tasks
vivekrnv
approved these changes
Jul 7, 2023
kellyyeh
approved these changes
Jul 10, 2023
|
@jcaiMR There seems to be unrelated text in PR description. Please remove before merging |
11 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 25, 2023
…rio (#15744) #### Why I did it 1. sonic-build image side change to fix source interface selection in dual tor scenario. dhcprelay related PR: sonic-net/sonic-dhcp-relay#40 2. Announce dhcprelay submodule to 3578eb3 (to invoke [#40](sonic-net/sonic-dhcp-relay#40 ) PR) ##### Work item tracking - Microsoft ADO 24243215 #### How to verify it run test case, dhcp_relay/test_dhcpv6_relay.py
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Fix DHCPv6 relay dual-tor relay-reply handling issue.
Other related docker change PR:
https://github.com/sonic-net/sonic-buildimage/pull/15744/files
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix DHCPv6 relay dual-tor relay-reply handling issue. In dual-tor scenario, we need responses from dhcpv6 server send to Active tor. Based on RFC8415 session [18.3.10], DHCPv6 server unicasts the Relay-reply message directly to the relay agent using the address in the source address field from the IP datagram in which the Relay-forward message was received. So in dual-tor we need use DUT unique loopback ipv6 address as relay-forward source (Vlan IPv6 is same on both active tor and standby tor).
Main changed in this PR:
How did you do it?
How did you verify/test it?
single-tor sanity testing no issue
dual-tor function test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation