Add gnmi_dump tool for debug and unit test #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Nov 14, 2022
| @@ -388,13 +404,11 @@ func (s *Server) Set(ctx context.Context, req *gnmipb.SetRequest) (*gnmipb.SetRe | |||
| /* Add to Set response results. */ | |||
| results = append(results, &res) | |||
| } | |||
| if s.config.EnableTranslibWrite { | |||
There was a problem hiding this comment.
I move the check to line 353 to simplify logic for set fail, when EnableTranslibWrite is false, no need to authenticate and no need to update result.
tomek-US
reviewed
Nov 16, 2022
common_utils/context.go
Outdated
| SetMemCounters(&globalCounters) | ||
| } | ||
|
|
||
| func IncCounter(name string) { |
There was a problem hiding this comment.
Why use string as an index? If an enum were used then there would be no need for the loop in line 81, right?
gnmi_server/server_test.go
Outdated
| func createReadServer(t *testing.T, port int64) *Server { | ||
| certificate, err := testcert.NewCert() | ||
| if err != nil { | ||
| t.Errorf("could not load server key pair: %s", err) |
There was a problem hiding this comment.
This should be t.Fatalf(...) as t.Errorf(...) does not stop execution of the test and it will continue despite lack of the certificate.
gnmi_server/server_test.go
Outdated
| cfg := &Config{Port: port, EnableTranslibWrite: false} | ||
| s, err := NewServer(cfg, opts) | ||
| if err != nil { | ||
| t.Errorf("Failed to create gNMI server: %v", err) |
There was a problem hiding this comment.
Similar comment here. This should be t.Fatalf(...) instead of t.Errorf(...)
| @@ -107,6 +107,25 @@ func createServer(t *testing.T, port int64) *Server { | |||
| return s | |||
| } | |||
|
|
|||
| func createReadServer(t *testing.T, port int64) *Server { | |||
| certificate, err := testcert.NewCert() | |||
There was a problem hiding this comment.
As this is a helper function it should be marked as such by calling t.Helper() at its beginning.
qiluo-msft
approved these changes
Nov 18, 2022
|
@tomek-US I have updated, would you like to review again? |
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Nov 28, 2022
Update sonic-gnmi submodule pointer to include the following: * 99bfa8f Remove LOGLEVEL DB since is no longer used ([sonic-net#56](sonic-net/sonic-gnmi#56)) * 6b0253a Add conditional check for split ([sonic-net#55](sonic-net/sonic-gnmi#55)) * ae72767 Add gnmi_dump tool for debug and unit test ([sonic-net#60](sonic-net/sonic-gnmi#60)) * 8226e46 Upgrade pipeline to use bullseye. ([sonic-net#58](sonic-net/sonic-gnmi#58)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
This was referenced Nov 29, 2022
ganglyu
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 29, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 10, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add tool for debug and unit test.
How I did it
Use share memory to support counters.
Move check for EnableTranslibWrite to beginning of Set(). This change will simplify the logic for gnmi set fail, and no need to authenticate when EnableTranslibWrite is false.
How to verify it
Build image and run unit test.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)