Fix the cfg variable configuration bug. #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ganglyu & @zbud-msft - Please provide your review/approval. |
|
Can you explain "the configuration will be abnormal"? What's the behavior? |
|
pls see log, it is two different variables with the same name. |
ganglyu
reviewed
Nov 30, 2022
| @@ -135,7 +135,6 @@ func main() { | |||
| } | |||
|
|
|||
| opts = []grpc.ServerOption{grpc.Creds(credentials.NewTLS(tlsCfg))} | |||
| cfg := &gnmi.Config{} | |||
| cfg.Port = int64(*port) | |||
| cfg.UserAuth = userAuth | |||
There was a problem hiding this comment.
We only need UserAuth here, can you remove line 138, 140 and 141?
ganglyu
approved these changes
Dec 1, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
var cfg was declared in line 62. Otherwise, the configuration will be abnormal.
How I did it
var cfg was declared in line 62. Otherwise, the configuration will be abnormal.
How to verify it
var cfg was declared in line 62. Otherwise, the configuration will be abnormal.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)