Fix gnmi cli hang #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
reviewed
Jan 4, 2023
patches/0001-Fix-gnmi_cli-hang.patch
Outdated
| From: zbud-msft <zainbudhwani@microsoft.com> | ||
| Date: Wed, 4 Jan 2023 00:07:04 +0000 | ||
| Subject: [PATCH] Fix gnmi_cli hang | ||
|
|
There was a problem hiding this comment.
Please add comment to explain your patch
There was a problem hiding this comment.
Fixed last patch by removing writing to channel inside cli_config. Combined fixes into existing patch
Makefile
Outdated
| @@ -53,6 +53,7 @@ $(GO_DEPS): go.mod $(PATCHES) swsscommon_wrap | |||
| patch -d vendor -p0 < patches/gnmi_path.patch | |||
| patch -d vendor -p0 < patches/gnmi_xpath.patch | |||
| git apply patches/0001-Updated-to-filter-and-write-to-file.patch | |||
| git apply patches/0001-Fix-gnmi_cli-hang.patch | |||
There was a problem hiding this comment.
This should be "0002-...."
There was a problem hiding this comment.
Combined into one patch
renukamanavalan
approved these changes
Jan 4, 2023
ganglyu
approved these changes
Jan 5, 2023
8 tasks
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 6, 2023
#### Why I did it Submodule update for sonic-gnmi Incorporates: d922a07 Zain Budhwani Wed Jan 4 21:27:32 2023 -0800 Fix gnmi cli hang (sonic-net/sonic-gnmi#69) #### How I did it Get latest updates
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
gnmi_cli will hang when trying to write to channel inside cli_config. Use one goroutine to write to term channel and check if received cnt == expected cnt, otherwise when sleep_cnt hits max term due to timeout
How I did it
How to verify it
Nightly tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)