Added support to render Feature Table has_global_scope field. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
using alternate name. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Runtime Metadata Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@anamehra @mlok-nokia for viz. |
judyjoseph
reviewed
May 17, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added support to render Feature Table
has_global_scopebased on DeviceRuntime Metadata
Why I did:
In some case we want to control a given feature should run in host/global namespace based on device runtime metadata. For example in case of chassis Linecard we want to run lldp on asic namespaces (front panel ports) and not on host/global (eth0 might be connected internally to the Supervisor and not to external management switch)
How I verify:
Manual Veriifcation
UT updated.