-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[mellanox]: Backport new kernel patches (#195)
0024-mlxsw-core-Fix-memory-leak-on-module-removal.patch torvalds/linux@adc80b6 @v5.10-rc2 0025-platform-x86-mlx-platform-Remove-PSU-EEPROM-configur.patch torvalds/linux@2bf5046 @v5.11-rc1 0026-platform-x86-mlx-platform-Remove-PSU-EEPROM-configur.patch torvalds/linux@912b341 @v5.11-rc1 regression tests have been performed against these patches on the Mellanox platform, no issue found. Signed-off-by: Kebo Liu <kebol@nvidia.com>
- Loading branch information
Showing
4 changed files
with
160 additions
and
0 deletions.
There are no files selected for viewing
56 changes: 56 additions & 0 deletions
56
patch/0024-mlxsw-core-Fix-memory-leak-on-module-removal.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
From adc80b6cfedff6dad8b93d46a5ea2775fd5af9ec Mon Sep 17 00:00:00 2001 | ||
From: Ido Schimmel <idosch@nvidia.com> | ||
Date: Sat, 24 Oct 2020 16:37:32 +0300 | ||
Subject: [PATCH] mlxsw: core: Fix memory leak on module removal | ||
|
||
Free the devlink instance during the teardown sequence in the non-reload | ||
case to avoid the following memory leak. | ||
|
||
unreferenced object 0xffff888232895000 (size 2048): | ||
comm "modprobe", pid 1073, jiffies 4295568857 (age 164.871s) | ||
hex dump (first 32 bytes): | ||
00 01 00 00 00 00 ad de 22 01 00 00 00 00 ad de ........"....... | ||
10 50 89 32 82 88 ff ff 10 50 89 32 82 88 ff ff .P.2.....P.2.... | ||
backtrace: | ||
[<00000000c704e9a6>] __kmalloc+0x13a/0x2a0 | ||
[<00000000ee30129d>] devlink_alloc+0xff/0x760 | ||
[<0000000092ab3e5d>] 0xffffffffa042e5b0 | ||
[<000000004f3f8a31>] 0xffffffffa042f6ad | ||
[<0000000092800b4b>] 0xffffffffa0491df3 | ||
[<00000000c4843903>] local_pci_probe+0xcb/0x170 | ||
[<000000006993ded7>] pci_device_probe+0x2c2/0x4e0 | ||
[<00000000a8e0de75>] really_probe+0x2c5/0xf90 | ||
[<00000000d42ba75d>] driver_probe_device+0x1eb/0x340 | ||
[<00000000bcc95e05>] device_driver_attach+0x294/0x300 | ||
[<000000000e2bc177>] __driver_attach+0x167/0x2f0 | ||
[<000000007d44cd6e>] bus_for_each_dev+0x148/0x1f0 | ||
[<000000003cd5a91e>] driver_attach+0x45/0x60 | ||
[<000000000041ce51>] bus_add_driver+0x3b8/0x720 | ||
[<00000000f5215476>] driver_register+0x230/0x4e0 | ||
[<00000000d79356f5>] __pci_register_driver+0x190/0x200 | ||
|
||
Fixes: a22712a96291 ("mlxsw: core: Fix devlink unregister flow") | ||
Signed-off-by: Ido Schimmel <idosch@nvidia.com> | ||
Reported-by: Vadim Pasternak <vadimp@nvidia.com> | ||
Tested-by: Oleksandr Shamray <oleksandrs@nvidia.com> | ||
Signed-off-by: Jakub Kicinski <kuba@kernel.org> | ||
--- | ||
drivers/net/ethernet/mellanox/mlxsw/core.c | 2 ++ | ||
1 files changed, 2 insertions(+), 0 deletions(-) | ||
|
||
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c | ||
index b67d610..e2faedc 100644 | ||
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c | ||
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c | ||
@@ -1135,6 +1135,8 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core, | ||
if (!reload) | ||
devlink_resources_unregister(devlink, NULL); | ||
mlxsw_core->bus->fini(mlxsw_core->bus_priv); | ||
+ if (!reload) | ||
+ devlink_free(devlink); | ||
|
||
return; | ||
|
||
-- | ||
1.7.1 | ||
|
51 changes: 51 additions & 0 deletions
51
patch/0025-platform-x86-mlx-platform-Remove-PSU-EEPROM-configur.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
From 2bf5046bdb649908df8bcc0a012c56eee931a9af Mon Sep 17 00:00:00 2001 | ||
From: Vadim Pasternak <vadimp@nvidia.com> | ||
Date: Wed, 25 Nov 2020 12:10:55 +0200 | ||
Subject: [PATCH] platform/x86: mlx-platform: Remove PSU EEPROM from default platform configuration | ||
|
||
Remove PSU EEPROM configuration for systems class equipped with | ||
Mellanox chip Spectrum and Celeron CPU - system types MSN2700, MSN2100. | ||
Till now all the systems from this class used few types of power units, | ||
all equipped with EEPROM device with address space two bytes. Thus, all | ||
these devices have been handled by EEPROM driver "24c02". | ||
|
||
There is a new requirement is to support power unit replacement by "off | ||
the shelf" device, matching electrical required parameters. Such device | ||
can be equipped with different EEPROM type, which could be one byte | ||
address space addressing or even could be not equipped with EEPROM. | ||
In such case "24c02" will not work. | ||
|
||
Fixes: c6acad68e ("platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface") | ||
Fixes: ba814fdd0 ("platform/x86: mlx-platform: Use defines for bus assignment") | ||
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> | ||
Link: https://lore.kernel.org/r/20201125101056.174708-2-vadimp@nvidia.com | ||
Signed-off-by: Hans de Goede <hdegoede@redhat.com> | ||
--- | ||
drivers/platform/x86/mlx-platform.c | 6 ++---- | ||
1 files changed, 2 insertions(+), 4 deletions(-) | ||
|
||
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c | ||
index d6c87fb..6400f1d 100644 | ||
--- a/drivers/platform/x86/mlx-platform.c | ||
+++ b/drivers/platform/x86/mlx-platform.c | ||
@@ -375,15 +375,13 @@ static struct mlxreg_core_data mlxplat_mlxcpld_default_psu_items_data[] = { | ||
.label = "psu1", | ||
.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET, | ||
.mask = BIT(0), | ||
- .hpdev.brdinfo = &mlxplat_mlxcpld_psu[0], | ||
- .hpdev.nr = MLXPLAT_CPLD_PSU_DEFAULT_NR, | ||
+ .hpdev.nr = MLXPLAT_CPLD_NR_NONE, | ||
}, | ||
{ | ||
.label = "psu2", | ||
.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET, | ||
.mask = BIT(1), | ||
- .hpdev.brdinfo = &mlxplat_mlxcpld_psu[1], | ||
- .hpdev.nr = MLXPLAT_CPLD_PSU_DEFAULT_NR, | ||
+ .hpdev.nr = MLXPLAT_CPLD_NR_NONE, | ||
}, | ||
}; | ||
|
||
-- | ||
1.7.1 | ||
|
50 changes: 50 additions & 0 deletions
50
patch/0026-platform-x86-mlx-platform-Remove-PSU-EEPROM-configur.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
From 912b341585e302ee44fc5a2733f7bcf505e2c86f Mon Sep 17 00:00:00 2001 | ||
From: Vadim Pasternak <vadimp@nvidia.com> | ||
Date: Wed, 25 Nov 2020 12:10:56 +0200 | ||
Subject: [PATCH] platform/x86: mlx-platform: Remove PSU EEPROM from MSN274x platform configuration | ||
|
||
Remove PSU EEPROM configuration for systems class equipped with | ||
Mellanox chip Spectrum and ATOM CPU - system types MSN274x. Till now | ||
all the systems from this class used few types of power units, all | ||
equipped with EEPROM device with address space two bytes. Thus, all | ||
these devices have been handled by EEPROM driver "24c02". | ||
|
||
There is a new requirement is to support power unit replacement by "off | ||
the shelf" device, matching electrical required parameters. Such device | ||
can be equipped with different EEPROM type, which could be one byte | ||
address space addressing or even could be not equipped with EEPROM. | ||
In such case "24c02" will not work. | ||
|
||
Fixes: ef08e14a3 ("platform/x86: mlx-platform: Add support for new msn274x system type") | ||
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com> | ||
Link: https://lore.kernel.org/r/20201125101056.174708-3-vadimp@nvidia.com | ||
Signed-off-by: Hans de Goede <hdegoede@redhat.com> | ||
--- | ||
drivers/platform/x86/mlx-platform.c | 6 ++---- | ||
1 files changed, 2 insertions(+), 4 deletions(-) | ||
|
||
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c | ||
index 6400f1d..c1d1a78 100644 | ||
--- a/drivers/platform/x86/mlx-platform.c | ||
+++ b/drivers/platform/x86/mlx-platform.c | ||
@@ -593,15 +593,13 @@ static struct mlxreg_core_data mlxplat_mlxcpld_msn274x_psu_items_data[] = { | ||
.label = "psu1", | ||
.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET, | ||
.mask = BIT(0), | ||
- .hpdev.brdinfo = &mlxplat_mlxcpld_psu[0], | ||
- .hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR, | ||
+ .hpdev.nr = MLXPLAT_CPLD_NR_NONE, | ||
}, | ||
{ | ||
.label = "psu2", | ||
.reg = MLXPLAT_CPLD_LPC_REG_PSU_OFFSET, | ||
.mask = BIT(1), | ||
- .hpdev.brdinfo = &mlxplat_mlxcpld_psu[1], | ||
- .hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR, | ||
+ .hpdev.nr = MLXPLAT_CPLD_NR_NONE, | ||
}, | ||
}; | ||
|
||
-- | ||
1.7.1 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters