Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to provision the ability of building with non-upstream patches #296

Merged
merged 8 commits into from
Oct 28, 2022

Conversation

vivekrnv
Copy link
Contributor

Dependent PR: sonic-net/sonic-buildimage#12428

Can be merged in any order

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Copy link
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patches. Please amend the commit messages to follow How to Write a Git Commit Message, and to clean it up.

Please also write a merge/pull request description describing the problem, and your solution. For example, it sounds like a directory non_upstream_patches is used by default. This has to be documented.

Lastly, what do you mean by upstream? https://www.kernel.org? Please clarify.

@liat-grozovik
Copy link
Collaborator

@saiarcot895 please help to review

Makefile Outdated Show resolved Hide resolved
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
@vivekrnv
Copy link
Contributor Author

Lastly, what do you mean by upstream? https://www.kernel.org? Please clarify.

It means patches that are not-yet or waiting to be upstreamed to mainline linux kernel. For a patch to be included in this repo, it has to be upstreamed in the mainline. This solution helps building the kernel with non-upstream patches (if any required)

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@saiarcot895 saiarcot895 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New comments

Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants