Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkout specific gnmi_ext version to fix build error #44

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Checkout specific gnmi_ext version to fix build error #44

merged 1 commit into from
Mar 25, 2020

Conversation

seiferteric
Copy link
Contributor

This is to fix build error:

../../../gopkgs/src/github.com/openconfig/gnmi/proto/gnmi_ext/gnmi_ext.pb.go:47:11: undefined: "github.com/golang/protobuf/proto".ProtoPackageIsVersion4

@renukamanavalan
Copy link

Looks similar to the last break. Will there be more to handle for correct commit-id?

@lguohan lguohan merged commit f789b29 into sonic-net:master Mar 25, 2020
@renukamanavalan renukamanavalan mentioned this pull request Mar 25, 2020
Merged
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Mar 25, 2020
@renukamanavalan
[submodule]: Update sonic-mgmt-framework to fix a build break fix. (#…
9d3ea75 
…4318)

Module updated: sonic-mgmt-framework
sonic-net/sonic-mgmt-framework#44
@jeff-yin
Copy link

@renukamanavalan -- I think so. Eric checked and remarked:

These are the imports (direct and indirect) that I see that are not yet locked to a commit id:

golang.org/x/crypto
golang.org/x/sys
golang.org/x/text
golang.org/x/net
gopkg.in/go-playground/validator.v9
google.golang.org/grpc
google.golang.org/genproto
google.golang.org/protobuf
github.com/golang/protobuf
github.com/golang/groupcache
github.com/go-playground/locales
github.com/go-playground/universal-translator
github.com/leodido/go-urn
github.com/kylelemons/godebug
github.com/google/go-cmp
github.com/antchfx/xpath
github.com/pborman/getopt

@renukamanavalan
Copy link

Thanks Jeff! The obvious next question, 'What is the plan for locking to the commit-id?'.

abdosi pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Mar 26, 2020
@renukamanavalan @abdosi
[submodule]: Update sonic-mgmt-framework to fix a build break fix. (#…
83c7770 
…4318)

Module updated: sonic-mgmt-framework
sonic-net/sonic-mgmt-framework#44
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
@renukamanavalan @tiantianlv
[submodule]: Update sonic-mgmt-framework to fix a build break fix. (s…
75df85a 
…onic-net#4318)

Module updated: sonic-mgmt-framework
sonic-net/sonic-mgmt-framework#44
@jeff-yin jeff-yin deleted the gnmi_ext_fix branch September 13, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@renukamanavalan renukamanavalan Awaiting requested review from renukamanavalan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seiferteric @renukamanavalan @jeff-yin @lguohan