Skip error messages for errors during SAI discovery

[roy-sror]

Skip error messages related to the following issue:
sonic-net/sonic-buildimage#7895

Summary:
Fixes # #10272

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012
• 202205
• 202305

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[roy-sror]

@ZhaohuiS , @lipxu - can you pls review

[ZhaohuiS]

@roy-sror which case is failed due to these error log? I suggest don't put the real error log into ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt, which we used to put non-harm or not real error logs needs to be ignored usually.
For your case, it's a real issue, could you please skip or xfail the impacted cases in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml. Please also add the conditions like platform,hwsku, or os version to limit the scope of skip or xfail.

[roy-sror]

@roy-sror which case is failed due to these error log? I suggest don't put the real error log into ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt, which we used to put non-harm or not real error logs needs to be ignored usually. For your case, it's a real issue, could you please skip or xfail the impacted cases in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml. Please also add the conditions like platform,hwsku, or os version to limit the scope of skip or xfail.

@ZhaohuiS - the error messages are discussed in sonic-net/sonic-buildimage#7895 and could happen on any boot. This is why tests/common/plugins/conditional_mark/tests_mark_conditions.yaml is less suitable in this case.

[bingwang-ms]

@roy-sror which case is failed due to these error log? I suggest don't put the real error log into ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt, which we used to put non-harm or not real error logs needs to be ignored usually. For your case, it's a real issue, could you please skip or xfail the impacted cases in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml. Please also add the conditions like platform,hwsku, or os version to limit the scope of skip or xfail.

@ZhaohuiS - the error messages are discussed in sonic-net/sonic-buildimage#7895 and could happen on any boot. This is why tests/common/plugins/conditional_mark/tests_mark_conditions.yaml is less suitable in this case.

Hi @roy-sror, issue sonic-net/sonic-buildimage#7895 is a quite old issue. Why didn't we see the same error log in other branch, like 202205?

[ZhaohuiS]

@roy-sror I don't know which case has these kinds of error log. bgp fib suppress? If there are some specific cases hit these error log during log analyzer, we can ignore these error log in script level or case level, please take the following one for reference.

https://github.com/sonic-net/sonic-mgmt/pull/10211/files

[bingwang-ms]

@roy-sror Can you please check and address the comments?

[roy-sror]

@bingwang-ms , @ZhaohuiS - Based on sonic-net/sonic-buildimage#7895, this might happen during any test that involves a reboot or configuration reload. To prevent having to add a skip statement for every test that involves a reload, I suggest keeping this globally skipped.

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[bingwang-ms]

@roy-sror Can you please address the pre_test static analysis failure?

[mssonicbld]

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Fixing ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt

check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
   the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
   docker container.
2. Ensure that the pre-commit package is installed:

sudo pip install pre-commit

3. Go to repository root folder
4. Install the pre-commit hooks:

pre-commit install

5. Use pre-commit to check staged file:

pre-commit

6. Alternatively, you can check committed files using:

pre-commit run --from-ref <commit_id> --to-ref <commit_id>

[nhe-NV]

/azpw run

[roy-sror]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[roy-sror]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[roy-sror]

@wangxin , @bingwang-ms - the checker failures are unrelated to the change and it is already failing for the 3rd time on a different issue. Is there a known stability issue of the tests/checkers? Can we merge this change?

[bingwang-ms]

I'm not aware of any known blocker in sonic-mgmt PR checker. Just retriggered the testing.

[bingwang-ms]

MFST ADO: 25581299
@StormLiangMS Can you please help cherry-pick to 202305 branch? Thanks!

[mssonicbld]

@roy-sror PR conflicts with 202305 branch

[bingwang-ms]

@roy-sror Can you please create another PR for 202305? Thanks!

[nhe-NV]

@bingwang-ms new PR added for 202305 branch: #11334

[wangxin]

This PR was merged before 202311 branch was created from master branch. No need to cherry-pick for 202311 branch.