[syslog] enable/disable syslog rate limit feature in fixture #10986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I61545db602d579fa0f337686427235c6d04998c7
nhe-NV
approved these changes
Dec 12, 2023
|
@Junchao-Mellanox the dependency is not accurate. can you please share the dependent PR? |
Updated |
liat-grozovik
approved these changes
Dec 25, 2023
|
Hi @StormLiangMS , could you help merge it in 202305? This should be the fix of ADO: 25971560 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 18, 2024
…et#10986) Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after. Summary: In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end. Change-Id: I61545db602d579fa0f337686427235c6d04998c7
|
Cherry-pick PR to 202305: #11315 |
|
@Junchao-Mellanox @wen587 do we need this for 202311? |
|
yes |
mssonicbld
pushed a commit
that referenced
this pull request
Jan 18, 2024
Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after. Summary: In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end. Change-Id: I61545db602d579fa0f337686427235c6d04998c7
mssonicbld
added
Included in 202305 branch
and removed
Created PR to 202305 branch
labels
|
This PR was merged before 202311 branch was created from master branch. No need to cherry-pick for 202311 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on sonic-net/sonic-buildimage#17458
Description of PR
Feature syslog rate limit has been disabled by default to avoid consume CPU cycles during warm / fast reboot. There are new CLIs to enable/disable it. The PR is to automatically enable it before syslog rate limit test and disable it after.
Summary:
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
Type of change
[ ] Bug fix
[ ] Testbed and Framework(new/improvement)
[x] Test case(new/improvement)
Back port request
[ ] 201911
[ ] 202012
[ ] 202205
[x] 202305
Approach
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
What is the motivation for this PR?
Align test code with production code change
How did you do it?
In fixture "restore_rate_limit", enable the feature at beginning, disable the feature at the end.
How did you verify/test it?
Run test case on local setup, all passed
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation