[dualtor-aa][nic_simulator] Improve the upstream flow #11459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(sonic-net#1), mod-flow will match both flow sonic-net#2 and flow sonic-net#3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
@yxieca, per previous discussion, add flag to enable/disable the nic upstream duplication. Please help review, thanks! |
yxieca
approved these changes
Feb 12, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 12, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow sonic-net#2 and flow sonic-net#3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
Cherry-pick PR to 202311: #11686 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 12, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow sonic-net#2 and flow sonic-net#3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
Cherry-pick PR to 202305: #11687 |
This was referenced Feb 12, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Feb 15, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow #2 and flow #3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld
pushed a commit
that referenced
this pull request
Feb 15, 2024
From the ovs doc, if mod-flow is used without --strict, priority is not used in matching. This will cause problem for downstream set_drop when duplicate_nic_upstream is disabled. For example: When set_drop is applied to upstream_nic_flow(#1), mod-flow will match both flow #2 and flow #3 as priority is not used in flow match. So let's enforce strict match for mod-flow. Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
8 tasks
vivekverma-arista
added a commit
to vivekverma-arista/sonic-mgmt
that referenced
this pull request
Mar 23, 2024
…nks." This change is not longer required as it was fixed by: sonic-net#11459 This reverts commit 45cb9ed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve the nic_simulator upstream nic traffic flow.
Currently, the upstream traffic from server nic is duplicated to both ToRs.
So the grpc traffic to the lower ToR could be forwarded to the upper ToR in such case, and those
traffic will go out the upper ToR via the default route though the port-channels. And those trivial traffic
will make some noises so some of the testcases that verify the port/queue counters will fail.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
Add two dedicated flows:
one to forward the traffic with upper ToR loopback IP to the upper ToR.
one to forward the traffic with lower ToR loopback IP to the lower ToR.
How did you verify/test it?
run
test_bgp_queuesand verify that the counters on tx queue 1 don't increase.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation