[tests/configlet] Update configlet test to align with swss update #12290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wen587
changed the title
yejianquan
reviewed
Apr 3, 2024
|
@wen587 Do we need this patch on other branches? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 5, 2024
…nic-net#12290) Approach What is the motivation for this PR? The swss introduce flap count and last flap time. The test fail because the two new fields mismatch. But these two fields are not affect the correctness of configlet test. sonic-net/sonic-swss#3052 How did you do it? Add two fields to skip val. How did you verify/test it? E2E test using the sonic-swss updated image. 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:359:02:31:34 patch_rm: compared dump state-db mismatch_cnt=0 msg= 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:385:02:31:34 patch_rm: generic_patch_rm_t0: Succeeded to compare 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/base_test.py:294:02:31:34 patch_rm: Test run is good! PASSED [100%] -------------------------------------------------------------------------------------------- live log teardown --------------------------------------------------------------------------------------------- co-authorized by: jianquanye@microsoft.com
|
Cherry-pick PR to 202311: #13984 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 5, 2024
…2290) Approach What is the motivation for this PR? The swss introduce flap count and last flap time. The test fail because the two new fields mismatch. But these two fields are not affect the correctness of configlet test. sonic-net/sonic-swss#3052 How did you do it? Add two fields to skip val. How did you verify/test it? E2E test using the sonic-swss updated image. 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:359:02:31:34 patch_rm: compared dump state-db mismatch_cnt=0 msg= 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:385:02:31:34 patch_rm: generic_patch_rm_t0: Succeeded to compare 02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/base_test.py:294:02:31:34 patch_rm: Test run is good! PASSED [100%] -------------------------------------------------------------------------------------------- live log teardown --------------------------------------------------------------------------------------------- co-authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Skip comparison of two new fields that introduced by swss update
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The swss introduce flap count and last flap time. The test fail because the two new fields mismatch. But these two fields are not affect the correctness of configlet test. sonic-net/sonic-swss#3052
How did you do it?
Add two fields to skip val.
How did you verify/test it?
E2E test using the sonic-swss updated image.
02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:359:02:31:34 patch_rm: compared dump state-db mismatch_cnt=0 msg=
02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/common.py:385:02:31:34 patch_rm: generic_patch_rm_t0: Succeeded to compare
02:31:34 helpers.log_msg L0060 INFO | /var/src/sonic-mgmt-int/tests/configlet/util/base_test.py:294:02:31:34 patch_rm: Test run is good!
PASSED [100%]
-------------------------------------------------------------------------------------------- live log teardown ---------------------------------------------------------------------------------------------
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation