-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix for Dynamic ACL via GCU ACL rule replacement test #12515
Temporary fix for Dynamic ACL via GCU ACL rule replacement test #12515
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
@yxieca Can you please help approve the cherry-pick? Thanks |
…c-net#12515) * Test to see if replace was the error
Cherry-pick PR to 202311: #12517 |
* Test to see if replace was the error
Description of PR
Summary:
Changes test_gcu_acl_forward_rule_replacement to separate the replacement operation into two separate delete and add operations. This is to address test failures caused by a SONiC OS bug that floods error logs after a ACL rule is directly replaced in configDB, despite ACL functionality working as intended - sonic-net/sonic-buildimage#18719
Test working on testbed that it previously failed on:
Type of change
Back port request
Approach
What is the motivation for this PR?
Temporarily fix test case to get rid of errors in nightly testing suite pending bug fix in SONiC OS
How did you do it?
Changed the replace operation into two separate delete and add operations
How did you verify/test it?
Tested it on a testbed that had previously been failing