Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add loganalyzer_common_ignore regexs for config reload on broadcom #13316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1edc9bb
Add loganalyzer_common_ignore regexs for config reload on broadcom pl…
byu343 Jun 15, 2024
c60570c
Remove regex for netlink and systemd-udev error
byu343 Jun 19, 2024
d927ddf
Remove regex for for port fdr stats
byu343 Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ansible/roles/test/files/tools/loganalyzer/loganalyzer_common_ignore.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ r, ".* ERR kernel:.* Module gpio_ich is blacklisted.*"
r, ".* skipping since it causes crash: SAI_STP_ATTR_BRIDGE_ID.*"
r, ".* ERR monit.*Expected containers not running: telemetry.*"

# Errors for config reload on broadcom platform on 202311
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute.*"
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute.*"
r, ".* ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute.*"
r, ".* ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"
r, ".* ERR syncd\d*#syncd.*SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters.* failed with error Feature unavailable.*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byu343 for the 5 lines above I understand they are caused by sonic-net/SONiC#1101 added by Nvidia. What I am not sure is the 3 lines below, Could you please clarify why you want to ignore them? What is the real root cause for those 3 lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"
Above two lines are from broadcom SAI for reading FEC counters on certain ports not supporting them.

r, ".* ERR swss#portsyncd: :- readData: netlink reports an error=-33 on reading a netlink socket."
r, ". ERR systemd-udevd[\d*]:.* bcm0: Failed to get link config: No such device.*"
We only see occasional issues with them from our testing results. I should remove them from the this change


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byu343 thank you for the update, but I still didn't find "port fdr stats get failed with error Feature unavailable" in our nightly test result. Probably, not related to sonic-net/SONiC#1101 as well. Can we remove it for now and add it back if we observe it in our nightly test and confirm that it's not image issue?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will create a separate PR for FEC counter error from broadcom SAI:
r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable."
r, ". ERR syncd\d*#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.*"

Copy link
Contributor

@ZhaohuiS ZhaohuiS Jun 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@byu343 I think we have some miscommunication here:
ERR syncd\d#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.* should be included this PR, since it is caused by sonic-net/SONiC#1101, same with ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute..
But I suggest don't include ERR syncd\d#syncd.SAI_API_PORT:brcm_sai_get_port_stats. port fdr stats get failed with error Feature unavailable.* in this PR, because I didn't find any of it in our nightly test.
Do you have other concerns or any misunderstanding here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ZhaohuiS,
My understanding is that the error for _brcm_sai_read_fec_stat_err_counters is from reading the FEC counter and unrelated to the query hash-related capacities in sonic-net/SONiC#1101. But anyway, I could add it to this PR for the same reason of unblocking log checking.

"port fdr stats get failed with error Feature unavailable" We saw this a lot on 7260 t0-116. We could put this in another PR in case we will need it later.

# White list below messages found on KVM for now. Need to address them later.
r, ".* ERR macsec#wpa_supplicant.*l2_packet_send.*Network is down.*"
r, ".* ERR macsec#wpa_supplicant.*could not process SIGINT or SIGTERM in two seconds.*"
Expand Down
Loading