Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:12959] Pin requests to version 2.31.0 in main.yml #13430

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

In latest requests python package, would got error in some steps like add-topo and restart-ptf with message 'Not supported URL scheme http+docker'
We already have fix PR #12910 in master branch to install stable requests version in docker.yml, but once package_installation was set to false like restart-ptf, docker.yml would skip and report error again

How did you do it?

Install stable requests version in main.yml after executing docker.yml to cover all scenario

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

What is the motivation for this PR?
In latest requests python package, would got error in some steps like add-topo and restart-ptf with message 'Not supported URL scheme http+docker'
We already have fix PR sonic-net#12910 in master branch to install stable requests version in docker.yml, but once package_installation was set to false like restart-ptf, docker.yml would skip and report error again

How did you do it?
Install stable requests version in main.yml after executing docker.yml to cover all scenario
@mssonicbld
Copy link
Collaborator Author

Original PR: #12959

@mssonicbld mssonicbld merged commit f032364 into sonic-net:202012 Jun 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants