Remove xfail marker of ecmp/test_ecmp_sai_value.py #13538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
|
@Gfrom2016 is the code change included in sonic-buildimage 202405 branch? |
I have added 'Request for 202405 image' label, will merge this after the image fix is merged. Thanks for the reminder. |
|
PR test re-triggeered. |
|
@StormLiangMS Could you help merge this? |
wangxin
approved these changes
Jul 9, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 9, 2024
What is the motivation for this PR? After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom. How did you do it? Remove the xfail marker of ecmp/test_ecmp_sai_value.py How did you verify/test it? Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
|
Cherry-pick PR to 202311: #13600 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 9, 2024
What is the motivation for this PR? After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom. How did you do it? Remove the xfail marker of ecmp/test_ecmp_sai_value.py How did you verify/test it? Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
8 tasks
|
Cherry-pick PR to 202405: #13601 |
8 tasks
|
@Gfrom2016 if the swss fix is merged in master, we have to remove skip for master and internal. |
@ZhaohuiS sure, I will raise another PR to un-skip the case |
mssonicbld
pushed a commit
that referenced
this pull request
Jul 10, 2024
What is the motivation for this PR? After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom. How did you do it? Remove the xfail marker of ecmp/test_ecmp_sai_value.py How did you verify/test it? Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
mssonicbld
added
Included in 202311 branch
and removed
Created PR to 202311 branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jul 10, 2024
What is the motivation for this PR? After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom. How did you do it? Remove the xfail marker of ecmp/test_ecmp_sai_value.py How did you verify/test it? Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
8 tasks
This was referenced Jul 15, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
What is the motivation for this PR? After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom. How did you do it? Remove the xfail marker of ecmp/test_ecmp_sai_value.py How did you verify/test it? Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed. https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes #11310
LAG and ECMP hash offset support has merged in 202311 sonic-net/sonic-swss#3138, remove the xfail marker of ecmp/test_ecmp_sai_value.py
Type of change
Back port request
Approach
What is the motivation for this PR?
After sonic-net/sonic-swss#3138, configure hash_offset along with hash_seed attribute is enabled on 202311 onwards on Broadcom T1 platfrom.
How did you do it?
Remove the xfail marker of ecmp/test_ecmp_sai_value.py
How did you verify/test it?
Run ecmp/test_ecmp_sai_values.py on 7260 T1 DUT and passed.
https://dev.azure.com/mssonic/internal/_build/results?buildId=586225&view=results
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation