[test_reboot]Wait a few seconds before checking the reboot-cause #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
approved these changes
Feb 9, 2020
|
@lguohan Could you please add the request-201811 label and then cherry-pick it to the 201811 branch? |
yxieca
pushed a commit
that referenced
this pull request
Feb 14, 2020
In the reboot cause test it is assumed that the reboot-cause is available as soon as the critical services ready. However, PR Delay process-reboot-cause service until network connection is stable #4003 introduces an extra amount of seconds and fails the assumption.
mykolaf
pushed a commit
to mykolaf/sonic-mgmt
that referenced
this pull request
Mar 11, 2020
…ic-net#1367) In the reboot cause test it is assumed that the reboot-cause is available as soon as the critical services ready. However, PR Delay process-reboot-cause service until network connection is stable sonic-net#4003 introduces an extra amount of seconds and fails the assumption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In the reboot cause test it is assumed that the reboot-cause is available as soon as the critical services ready. However, PR Delay process-reboot-cause service until network connection is stable #4003 introduces an extra amount of seconds and fails the assumption.
Type of change
Approach
How did you do it?
Wrap the reboot-cause-check into a wait-until logic so that it can wait for the process-reboot-cause for a few seconds.
How did you verify/test it?
Run reboot cause test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation