[action] [PR:12932] Fix add-topo failure when deploying topology with empty VM list. #14166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic-net#12932) What is the motivation for this PR? There are 2 issues are hitting, when deploying any topology without the VM list: Ansible Bind topology to VMs task task will fail, because the vm list is empty, but it is checking the VM base in the VM list. The generated minigraph will fail to load, because minigraph.py is not expecting any ACL interface with empty attached to list. How did you do it? This change fixes both issue with adding the empty list checks in these 2 places. How did you verify/test it? Run the add-topo and deploy-mg locally, both works. Any platform specific information? No.
8 tasks
|
Original PR: #12932 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
When deploying any topology without the VM list as below, we will running into a few errors. And this PR is to fix these issues:
Type of change
Back port request
Approach
What is the motivation for this PR?
There are 2 issues are hitting, when deploying any topology without the VM list:
How did you do it?
This change fixes both issue with adding the empty list checks in these 2 places.
How did you verify/test it?
Run the add-topo and deploy-mg locally, both works.
Any platform specific information?
No.
Supported testbed topology if it's a new test case?
N/A
Documentation
N/A