Skip BGPAllowListMgr syslog in test_bgp_prefix_tc1_suite for Cisco 8111 CompuateAI deployment #14367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinskwang
reviewed
Sep 3, 2024
| """Ignore expected failures logs during test execution.""" | ||
| if loganalyzer: | ||
| IgnoreRegex = [ | ||
| ".*ERR bgp#bgpcfgd: BGPAllowListMgr::Default action community value is not found.*", |
There was a problem hiding this comment.
test_bgp_prefix_tc1_suite is to add the prefix in the allow list, it should not care if we have the allow list by default or not. Could you indicate why we still need to ignore this error?
There was a problem hiding this comment.
Testcase didn't care about allow list. It is the BGPAllowListMgr script in the image will check the allow list, which will cause the syslog error, then captured by log analyzer.
kevinskwang
approved these changes
Sep 3, 2024
|
Cherry-pick PR to 202311: #14390 |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 3, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 3, 2024
|
Cherry-pick PR to 202305: #14392 |
8 tasks
|
Cherry-pick PR to 202405: #14391 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Sep 3, 2024
hdwhdw
pushed a commit
to hdwhdw/sonic-mgmt
that referenced
this pull request
Sep 20, 2024
arista-hpandya
pushed a commit
to arista-hpandya/sonic-mgmt
that referenced
this pull request
Oct 2, 2024
vikshaw-Nokia
pushed a commit
to vikshaw-Nokia/sonic-mgmt
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Skip BGPAllowListMgr syslog in test_bgp_prefix_tc1_suite for Cisco 8111 CompuateAI deployment
Type of change
Back port request
Approach
What is the motivation for this PR?
Skip BGPAllowListMgr syslog in test_bgp_prefix_tc1_suite for Cisco 8111 CompuateAI deployment
Cisco 8111 ComputeAI deployment does NOT use allow list like ALLOW_LIST_DEPLOYMENT_ID_0_V4, ALLOW_LIST_DEPLOYMENT_ID_0_V6
How did you do it?
Add syslog pattern to ignore list.
How did you verify/test it?
Test with physical testbed.
Run with cli:
./run_tests.sh -i ../ansible/str3,../ansible/veos -r -l info -u -m individual -e "--skip_sanity" -n vms66-t1-8111-01 -c generic_config_updater/test_bgp_prefix.py::test_bgp_prefix_tc1_suiteGet result:
======================================================== 2 passed, 1 warning in 312.84s (0:05:12) =========================================================Any platform specific information?
Cisco 8111 ComputeAI deployment
Supported testbed topology if it's a new test case?
Documentation