Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicted skipping condition for test_pfc_asym #15327

Merged

Conversation

bingwang-ms
Copy link
Collaborator

Description of PR

Summary:
Fixes conflicted skipping condition for test_pfc_asym.
Before this change, there are two skipping conditions.

#######################################
#####         pfc_asym            #####
#######################################
pfc_asym/test_pfc_asym.py:
  skip:
    reason: 'pfc_asym test skip except for on Barefoot platforms'
    conditions:
      - "asic_type not in ['barefoot']"

pfc_asym/test_pfc_asym.py::test_pfc_asym_off_rx_pause_frames:
   skip:
     reason: "skipped for Barefoot platform"
     conditions:
        - "asic_type in ['barefoot']"

This PR reomoved the second one as it has been covered by the first one.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

This PR is to fix conflicted skipping condition for test_pfc_asym.

How did you do it?

Remove the unused condition.

How did you verify/test it?

Verified by syntax check.

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

Not a new test case.

Documentation

@bingwang-ms bingwang-ms merged commit dd6bafb into sonic-net:master Nov 6, 2024
16 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Nov 6, 2024
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #15371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants