Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:14713] [T2] [Chassis] Skip override_config_table_masic test for upstream line card #15612

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)
This PR fixes 'test_override_config_table_masic-test_load_minigraph_with_golden_config' failure on upstream line card on T2 topo Chassis.

The above test fails with the following issue on DEVICE_METADATA table when 'config load_minigraph' is done with empty golden config input.

host_current_config = get_running_config(duthost)
for table in initial_host_config:
if table in NON_USER_CONFIG_TABLES:
continue
pytest_assert(
initial_host_config[table] == host_current_config[table],
"empty input compare fail! {}".format(table)
)
E Failed: empty input compare fail! DEVICE_METADATA

The test passes on downstream linecards.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

  • 'test_override_config_table_masic-test_load_minigraph_with_golden_config' fails on upstream line card on T2 topo Chassis.
  • 'subtype' changes to 'DownstreamLC' from 'UpstreamLC' in DEVICE_METADATA for Upstream LC after load_minigraph with empty golden_config as input.

How did you do it?

  • Skip the empty input golden config check for upstream line card and do the other checks for upstream line card.
  • Perform the empty input test only if it is downstream line card and verify the golden config functionality.

How did you verify/test it?

Run 'test_override_config_table_masic-test_load_minigraph_with_golden_config' on T2 chassis and verify the test passes without any issues.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

image

…e card (sonic-net#14713)

* Skip empty input golden config check for upstream-t2 linecard
@mssonicbld
Copy link
Collaborator Author

Original PR: #14713

@mssonicbld mssonicbld merged commit a3c55dd into sonic-net:202405 Nov 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants