[deploy-mg][mx] Fix generate golden config db failed in mx with OS version doesn't support dhcp_server #16086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
w1nda
approved these changes
Dec 16, 2024
wangxin
approved these changes
Dec 17, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 17, 2024
…rsion doesn't support dhcp_server (sonic-net#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP sonic-net#15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
|
Cherry-pick PR to 202405: #16113 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Dec 30, 2024
…rsion doesn't support dhcp_server (#16086) What is the motivation for this PR? Golden config db var has been changed from json like string to dict by this RP #15922 But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure How did you do it? Change empty golden config generated for mx doesn't support dhcp_server How did you verify/test it? Deploy-mg
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Golden config db var has been changed from json like string to dict by this RP #15922
But for mx with OS version doesn't support dhcp_server, it would still generate empty json like string, which would cause failure
How did you do it?
Change empty golden config generated for mx doesn't support dhcp_server
How did you verify/test it?
Deploy-mg
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation