Upgrade path fixes and improvements #2424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yxieca
reviewed
Oct 30, 2020
| @@ -30,7 +30,9 @@ | |||
|
|
|||
| def exec_command(module, cmd, ignore_error=False, msg="executing command"): | |||
| rc, out, err = module.run_command(cmd) | |||
| if not ignore_error and rc != 0: | |||
| if ignore_error: | |||
| return rc, out, err | |||
There was a problem hiding this comment.
You should restore the original code structure and change line 38 instead. With your change, the succeeded path will return different number of return values.
yxieca
reviewed
Oct 30, 2020
bingwang-ms
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Improvements added to:
/host/if the installation fails.warm-reboothas to be forced-fto get past theASIC Configuration changederror.Type of change
What is the motivation for this PR?
If the image installation fails, the stale image remains in the DUT
/host/directory which takes up the space unnecessarily.Also, added support for image upgrade from 201811 to 201911.
How did you verify/test it?
Tested upgrade from
201811-201811,201911-201911and201811-201911(presently fails due todb_migratorerror that this testcase discovered (sonic-net/sonic-buildimage#5738)Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation