[test]add more ARP and neighbor-mac tests #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggiemsft
requested review from
lguohan,
stcheng,
pavel-shirshov and
marian-pritsak
lguohan
reviewed
Oct 18, 2017
ansible/library/switch_arptable.py
Outdated
| @@ -59,7 +102,7 @@ def main(): | |||
| if arp_tbl == None: | |||
There was a problem hiding this comment.
based on the impl, it can never return None. It can only throw exception, you need to catch exception.
lguohan
reviewed
Oct 18, 2017
| @@ -37,6 +37,36 @@ def runTest(self): | |||
| send_packet(self, 1, pkt) | |||
| verify_packet(self, exp_pkt, 1) | |||
|
|
|||
| class ExpectUnicastReply(acs_base_test.ACSDataplaneTest): | |||
There was a problem hiding this comment.
the function name is confusing.
ExpectUnicatReply mean expect unicast reply. What your function really does is SendUnicastArpRequest, I prefer function name to be VerifyUnicastArpRequest. #Resolved
lguohan
reviewed
Oct 18, 2017
| # - debug: var=arptable | ||
|
|
||
| - fail: msg="cannot find a IPv4 and IPv6 neighbor to change mac address" | ||
| when: ( arptable.v4 | length == 0 ) or ( arptable.v6 | length == 0 ) |
There was a problem hiding this comment.
we do not need to fail if there is no neighbor, we can just first create a neigbhor entry.
lguohan
reviewed
Oct 18, 2017
| with_dict: "{{ arptable.v6 }}" | ||
| when: | ||
| - "'fe80::' not in item.key | lower" | ||
| - ('Ethernet' in item.value['interface']) or ('PortChannel' in item.value['interface']) |
lguohan
reviewed
Oct 18, 2017
| @@ -2,6 +2,9 @@ | |||
| # Test run example: | |||
| # ansible-playbook -i inventory --limit arc-switch1027 test_sonic.yml -b -e "ptf_host=ptf-1" --tags neighbour | |||
|
|
|||
| - name: Add a new test to test SONiC kernel change neighbor mac address, no ptf neighbor requried | |||
| include: neighbour-mac-noptf.yml | |||
There was a problem hiding this comment.
let's add this to the sonic.yml make it independent of neighour-mac.yml
lguohan
approved these changes
Oct 20, 2017
|
we need later consider mac address change on the vlan interface. |
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* msft_github/master: [test]: Add ptf_platform_dir: ptftests to enable more than 32 ports testbed (sonic-net#315) [bgp_speaker]: Support t0-64 topology (sonic-net#316) [Minigraph Templates]: Add new <DhcpRelays> node to Vlans as appropriate (sonic-net#298) [sensors]: Add comment to indicate the sensors data file path [ptf_runner]: Add ptf_platform_dir option to indicate --platform-dir option (sonic-net#304) Make fetch command arguments supported by newer ansible version (sonic-net#310) [arista7260cx3] define t0 116 ports topology [fast-reboot test]: Cosmetic fixes (sonic-net#307) [test]add more ARP and neighbor-mac tests (sonic-net#303) After boot_onie, admin up all bgp interfaces (sonic-net#306) Update README.test.md add test case bgp multipath relax (sonic-net#284) [minigraph]: Remove unnecessary quotes (sonic-net#301)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR covers 2 issues: #287; #302