Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test_techsupport]: Add new test cases for remove password and certs from show techsupport result. #4767

Merged
merged 10 commits into from
Dec 3, 2021
Merged

[test_techsupport]: Add new test cases for remove password and certs from show techsupport result. #4767

merged 10 commits into from
Dec 3, 2021

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Nov 26, 2021

Description of PR

Add new test cases for remove password and certs from show techsupport result.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Add E2E test case coverage for remove password and certs from show techsupport result.

How did you do it?

Add new E2E test case to cover user scenarios.

How did you verify/test it?

Run new UT make sure they are all pass.
Make sure all current UT not break during merge validation.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

Documentation

@liuh-80 liuh-80 requested a review from a team as a code owner November 26, 2021 02:09
@lgtm-com
Copy link

lgtm-com bot commented Nov 26, 2021

This pull request introduces 1 alert when merging dd27650 into 54dec75 - view on LGTM.com

new alerts:

  • 1 for Unused argument in a formatting call

@liuh-80
Copy link
Contributor Author

liuh-80 commented Nov 29, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Returns:
None.
"""
skip_release(duthost, ["201811", "201911", "202012", "202106"])
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

201911

We plan to backport the feature sonic-net/sonic-utilities#1886 to 201911 and later branches. Could you not skip them? #Pending

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add these back after backport finish?
because if we make the UT run on those branch today, UT will fail and block some PRs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2021

This pull request introduces 1 alert when merging 75399f2 into ce83bca - view on LGTM.com

new alerts:

  • 1 for Unused argument in a formatting call

@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2021

This pull request introduces 1 alert when merging 4b592a8 into ce83bca - view on LGTM.com

new alerts:

  • 1 for Unused argument in a formatting call

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2021

This pull request introduces 1 alert when merging 8fd466b into 94340bb - view on LGTM.com

new alerts:

  • 1 for Unused argument in a formatting call

@liuh-80
Copy link
Contributor Author

liuh-80 commented Dec 2, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80 liuh-80 merged commit d9be132 into sonic-net:master Dec 3, 2021
AntonHryshchuk pushed a commit to AntonHryshchuk/sonic-mgmt that referenced this pull request Jan 4, 2022
…from show techsupport result. (sonic-net#4767)

### Description of PR
    Add new test cases for remove password and certs from show techsupport result.

### Type of change
- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [x] Test case(new/improvement)


### Back port request

### Approach
#### What is the motivation for this PR?
    Add E2E test case coverage for remove password and certs from show techsupport result.

#### How did you do it?
   Add new E2E test case to cover user scenarios.

#### How did you verify/test it?
   Run new UT make sure they are all pass.
   Make sure all current UT not break during merge validation.

#### Any platform specific information?
   N/A

#### Supported testbed topology if it's a new test case?

### Documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants