Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCU empty input test to verify functional usage and valid configDB #5459

Closed
wants to merge 1 commit into from

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Apr 2, 2022

Description of PR

Summary: Add empty input test before GCU tests to check GCU feature and if current configDB is valid
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

During PR test, there will have some changes on config DB. If the configDB does not pass yang validation, it will fail on the first GCU test: generic_config_updater/test_aaa.py. This empty input test is to verify if it is an invalid config DB causes the failure.

How did you do it?

Add empty input test case.

How did you verify/test it?

Run test of sonic-mgmt/tests/generic_config_updater/test_empty_input.py on KVM

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@qiluo-msft
Copy link
Contributor

If your intention is to test "there will have change on config DB. It will fail on generic_config_updater/test_aaa.py". Then you need to add a new test case into test_aaa.py. The testcase has a pre-condition of configDB changing in some specific way.

If your intention is to test "invalid config DB cause the failure". I think it has nothing to do with test_aaa.py. Then you can use a test case like in your PR, and the test case has a pre-condition of invalid configDB.

@wen587
Copy link
Contributor Author

wen587 commented Apr 6, 2022

If your intention is to test "there will have change on config DB. It will fail on generic_config_updater/test_aaa.py". Then you need to add a new test case into test_aaa.py. The testcase has a pre-condition of configDB changing in some specific way.

If your intention is to test "invalid config DB cause the failure". I think it has nothing to do with test_aaa.py. Then you can use a test case like in your PR, and the test case has a pre-condition of invalid configDB.

I mean the second intention. It fails at test_aaa.py just because it is the first GCU test. Also update in Description

logger = logging.getLogger(__name__)

@pytest.fixture(autouse=True)
def setup_env(duthosts, rand_one_dut_hostname):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup_env

Seems that you are assume there is some pre-condition before you run this test case.

Suggest make the pre-condition of invalid configDB explicit. So it will always be tested in a reproducible fashion.

@wen587 wen587 closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants