[generic_config_updater] add GCU ignore regex #5509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxin
reviewed
Apr 14, 2022
| @@ -28,6 +28,9 @@ def ignore_expected_loganalyzer_exceptions(duthost, loganalyzer): | |||
| ".*ERR swss[0-9]*#orchagent: :- getPortOperSpeed.*", # test_portchannel_interface replace mtu | |||
| ".*ERR.*Failed to apply Json change.*", # validator need updater submodule | |||
| ".*ERR GenericConfigUpdater: Change Applier: service invoked.*", # validator need updater submodule | |||
| ".*getResAvailableCounters.*", # test_monitor_config | |||
| ".*objectTypeGetAvailability.*", # test_monitor_config | |||
| ".*ERR dhcp_relay.*", # test_dhcp_relay | |||
There was a problem hiding this comment.
The pattern is too generic. Can you prepend the module generated these messages?
BTW, can you also change the scope of this fixture to module level?
There was a problem hiding this comment.
I've update the first two pattern. The dhcp_relay ERR seems random failure. The msg looks like below. So I just wrap them into one.
['Apr 11 17:53:27.057936 vlab-01 ERR dhcp_relay#dhcrelay[38]: setsockopt: SO_BINDTODEVICE: No such device\n',
'Apr 11 17:53:27.057936 vlab-01 ERR dhcp_relay#dhcrelay[38]: \n',
'Apr 11 17:53:27.057948 vlab-01 ERR dhcp_relay#dhcrelay[38]: If you think you have received this message due to a bug rather\n',
'Apr 11 17:53:27.057948 vlab-01 ERR dhcp_relay#dhcrelay[38]: than a configuration issue please read the section on submitting\n',
'Apr 11 17:53:27.057948 vlab-01 ERR dhcp_relay#dhcrelay[38]: bugs on either our web page at www.isc.org or in the README file\n',
'Apr 11 17:53:27.057962 vlab-01 ERR dhcp_relay#dhcrelay[38]: before submitting a bug. These pages explain the proper\n',
'Apr 11 17:53:27.057962 vlab-01 ERR dhcp_relay#dhcrelay[38]: process and the information we find helpful for debugging.\n',
'Apr 11 17:53:27.057973 vlab-01 ERR dhcp_relay#dhcrelay[38]: \n',
'Apr 11 17:53:27.057973 vlab-01 ERR dhcp_relay#dhcrelay[38]: exiting.\n'
There was a problem hiding this comment.
Looks like loganalyzer fixture is function level.
qiluo-msft
approved these changes
Apr 14, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Add regex to unblock PR check
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add gcu ignore regex to unblock PR check
How did you do it?
Add regex pattern
How did you verify/test it?
Run unit test locally
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation